fix __new__ typing for OpenApiModel
#2433
Conversation
ava-silver
changed the title
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
ava-silver
changed the title
__new__ typing for OpenApiModel
| @@ -173,6 +173,18 @@ class OpenApiModel(object): | |||
| """Get the value of an attribute using dot notation: `instance.attr`.""" | |||
| return self.__getitem__(attr) | |||
|
|
|||
| @overload | |||
| def __new__(cls, arg: None) -> None: | |||
| ... | |||
There was a problem hiding this comment.
Is there a difference between this as pass?
There was a problem hiding this comment.
nope! ... (or the singleton Ellipsis) in python is just a convention used to indicate that it is not the real implementation, whereas pass is usually used when the implementation is intentionally blank (like with try: ... except: pass)
There was a problem hiding this comment.
tldr they both do nothing, but conventionally you would use ellipses for overload signature bodies
There was a problem hiding this comment.
The docs for overload also use ... in their example usage.
|
/merge |
|
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
[email protected] unqueued this merge request |
|
/merge -c |
|
View all feedbacks in Devflow UI. |
dd-devflow
bot
added
mergequeue-status: removed
and removed
mergequeue-status: waiting
labels
|
/merge |
|
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
devflow unqueued this merge request: It did not become mergeable within the expected time |
dd-devflow
bot
added
mergequeue-status: waiting
mergequeue-status: removed
and removed
mergequeue-status: removed
mergequeue-status: waiting
labels
ava-silver
force-pushed
the
ava.silver/typing/fix-__new__-typing-for-openapimodel
branch
from
9a34c24 to
4745276
Compare
| @@ -173,6 +173,18 @@ class OpenApiModel(object): | |||
| """Get the value of an attribute using dot notation: `instance.attr`.""" | |||
| return self.__getitem__(attr) | |||
|
|
|||
| @overload | |||
| def __new__(cls, arg: None) -> None: # type: ignore | |||
There was a problem hiding this comment.
had to add the type ignore because mypy (in CI) doesn't like this, but we do this in the code already, we just didn't reflect that in the typing before
ava-silver
deleted the
ava.silver/typing/fix-__new__-typing-for-openapimodel
branch
What does this PR do?
Fixes the typing on
__new__and makes constructors typing behave properly.before:
after:
Additional Notes
Review checklist
Please check relevant items below:
This PR includes all newly recorded cassettes for any modified tests.
This PR does not rely on API client schema changes.
Or, this PR relies on API schema changes and this is a Draft PR to include tests for that new functionality.