Skip to content

feat: add process tags to tracing payloads #3566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 2, 2025

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented May 29, 2025

What does this PR do?

Adds a new _dd.tags.process trace-level tag (equivalent to the following DataDog/dd-trace-java#8698), which will allow users to rename their services.

The initially collected tags for Go are:

  • "entrypoint.name"
  • "entrypoint.basedir"
  • "entrypoint.workdir"
  • "entrypoint.type"

But these could be extended in the future, and might be collected and added by some contribs (e.g. the grpc service name or similar).

By default the collection of these tags is disabled, and is enabled using the environment variable: DD_EXPERIMENTAL_PROPAGATE_PROCESS_TAGS_ENABLED.

There will be a number of follow-up PRs adding this data to the payloads for:

  • Stats
  • Profiling
  • Remoteconfig
  • DSM
  • Telemetry

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@rarguelloF rarguelloF marked this pull request as ready for review May 29, 2025 14:10
@rarguelloF rarguelloF requested review from a team as code owners May 29, 2025 14:10
@pr-commenter
Copy link

pr-commenter bot commented May 29, 2025

Benchmarks

Benchmark execution time: 2025-06-02 12:58:34

Comparing candidate commit 9c8a429 in PR branch rarguelloF/process-tags-tracing with baseline commit f2441d3 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 21 metrics, 0 unstable metrics.

@rarguelloF rarguelloF requested review from darccio and amarziali May 29, 2025 15:20
@rarguelloF rarguelloF requested a review from raphaelgavache May 29, 2025 16:37
@rarguelloF rarguelloF requested a review from amarziali June 2, 2025 09:06
@rarguelloF
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 2, 2025

View all feedbacks in Devflow UI.

2025-06-02 09:11:34 UTC ℹ️ Start processing command /merge


2025-06-02 09:11:38 UTC ℹ️ MergeQueue: queue is disabled

Added to the queue but the mergequeue is not enabled for now.


2025-06-02 12:48:04 UTCMergeQueue: This merge request was updated

This PR is rejected because it was updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants