Skip to content

Fixed OOM in lettuce-4 tests. #8935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2025
Merged

Fixed OOM in lettuce-4 tests. #8935

merged 1 commit into from
Jun 6, 2025

Conversation

AlexeyKuznetsov-DD
Copy link
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD commented Jun 5, 2025 •
edited
Loading

What Does This Do

Fixed OOM in lettuce-4 tests.

Motivation

Green CI.

Additional Notes

Found leaked Redis client.

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD self-assigned this Jun 5, 2025
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD added type: bug comp: testing Testing tag: no release notes Changes to exclude from release notes labels Jun 5, 2025
@pr-commenter
Copy link

pr-commenter bot commented Jun 5, 2025

Benchmarks

Startup

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-06-05T20:33:00 2025-06-05T20:40:26
git_branch master alexeyk/fixed-oom
git_commit_date 1749044153 1749154366
git_commit_sha 7787af7 1efd6f9
release_version 1.50.0-SNAPSHOT~7787af738f 1.50.0-SNAPSHOT~1efd6f91e9
start_time 2025-06-05T20:32:47 2025-06-05T20:39:40
See matching parameters
Baseline Candidate
application petclinic petclinic
ci_job_date 1749156026 1749156026
ci_job_id 970916587 970916587
ci_pipeline_id 67120761 67120761
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-z87jatgw-project-304-concurrent-0-uct8pp3b 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-z87jatgw-project-304-concurrent-0-uct8pp3b 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
thresholds_or_results results results
variant appsec appsec

Summary

Found 0 performance improvements and 3 performance regressions! Performance is the same for 0 metrics, 9 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:iast unstable
[+76.188ms; +79.960ms] or [+718.673%; +754.261%]		 worse
[-428.725op/s; -393.241op/s] or [-91.996%; -84.382%]		 88.675ms 55.043op/s 10.601ms 466.026op/s
scenario:load:petclinic:no_agent worse
[+9.929ms; +10.197ms] or [+129.042%; +132.520%]		 worse
[-382.594op/s; -338.283op/s] or [-59.780%; -52.857%]		 17.757ms 279.561op/s 7.694ms 640.000op/s

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alexeyk/fixed-oom
git_commit_date 1749044153 1749154366
git_commit_sha 7787af7 1efd6f9
release_version 1.50.0-SNAPSHOT~7787af738f 1.50.0-SNAPSHOT~1efd6f91e9
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1749156449 1749156449
ci_job_id 970916588 970916588
ci_pipeline_id 67120761 67120761
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-n-2qzcrt-project-304-concurrent-1-6fj1vlxz 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-n-2qzcrt-project-304-concurrent-1-6fj1vlxz 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~1efd6f91e9, baseline=1.50.0-SNAPSHOT~7787af738f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
.   : milestone, 1472,
appsec (2.388 ms) : 2339, 2436
.   : milestone, 2388,
iast (2.176 ms) : 2115, 2237
.   : milestone, 2176,
iast_GLOBAL (2.217 ms) : 2155, 2278
.   : milestone, 2217,
profiling (2.036 ms) : 1986, 2085
.   : milestone, 2036,
tracing (1.992 ms) : 1946, 2039
.   : milestone, 1992,
section candidate
no_agent (1.472 ms) : 1460, 1483
.   : milestone, 1472,
appsec (2.38 ms) : 2332, 2428
.   : milestone, 2380,
iast (2.185 ms) : 2124, 2246
.   : milestone, 2185,
iast_GLOBAL (2.222 ms) : 2161, 2284
.   : milestone, 2222,
profiling (2.026 ms) : 1976, 2075
.   : milestone, 2026,
tracing (2.005 ms) : 1958, 2052
.   : milestone, 2005,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.46 ms, 1.483 ms] -
appsec 2.388 ms [2.339 ms, 2.436 ms] 916.099 µs (62.2%)
iast 2.176 ms [2.115 ms, 2.237 ms] 704.296 µs (47.9%)
iast_GLOBAL 2.217 ms [2.155 ms, 2.278 ms] 744.763 µs (50.6%)
profiling 2.036 ms [1.986 ms, 2.085 ms] 563.849 µs (38.3%)
tracing 1.992 ms [1.946 ms, 2.039 ms] 520.603 µs (35.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.46 ms, 1.483 ms] -
appsec 2.38 ms [2.332 ms, 2.428 ms] 908.136 µs (61.7%)
iast 2.185 ms [2.124 ms, 2.246 ms] 713.405 µs (48.5%)
iast_GLOBAL 2.222 ms [2.161 ms, 2.284 ms] 750.75 µs (51.0%)
profiling 2.026 ms [1.976 ms, 2.075 ms] 554.069 µs (37.6%)
tracing 2.005 ms [1.958 ms, 2.052 ms] 533.376 µs (36.2%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~1efd6f91e9, baseline=1.50.0-SNAPSHOT~7787af738f
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.684 s) : 14684000, 14684000
.   : milestone, 14684000,
appsec (14.645 s) : 14645000, 14645000
.   : milestone, 14645000,
iast (18.659 s) : 18659000, 18659000
.   : milestone, 18659000,
iast_GLOBAL (18.314 s) : 18314000, 18314000
.   : milestone, 18314000,
profiling (15.156 s) : 15156000, 15156000
.   : milestone, 15156000,
tracing (14.671 s) : 14671000, 14671000
.   : milestone, 14671000,
section candidate
no_agent (15.289 s) : 15289000, 15289000
.   : milestone, 15289000,
appsec (14.789 s) : 14789000, 14789000
.   : milestone, 14789000,
iast (18.858 s) : 18858000, 18858000
.   : milestone, 18858000,
iast_GLOBAL (17.848 s) : 17848000, 17848000
.   : milestone, 17848000,
profiling (15.293 s) : 15293000, 15293000
.   : milestone, 15293000,
tracing (14.889 s) : 14889000, 14889000
.   : milestone, 14889000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.684 s [14.684 s, 14.684 s] -
appsec 14.645 s [14.645 s, 14.645 s] -39.0 ms (-0.3%)
iast 18.659 s [18.659 s, 18.659 s] 3.975 s (27.1%)
iast_GLOBAL 18.314 s [18.314 s, 18.314 s] 3.63 s (24.7%)
profiling 15.156 s [15.156 s, 15.156 s] 472.0 ms (3.2%)
tracing 14.671 s [14.671 s, 14.671 s] -13.0 ms (-0.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.289 s [15.289 s, 15.289 s] -
appsec 14.789 s [14.789 s, 14.789 s] -500.0 ms (-3.3%)
iast 18.858 s [18.858 s, 18.858 s] 3.569 s (23.3%)
iast_GLOBAL 17.848 s [17.848 s, 17.848 s] 2.559 s (16.7%)
profiling 15.293 s [15.293 s, 15.293 s] 4.0 ms (0.0%)
tracing 14.889 s [14.889 s, 14.889 s] -400.0 ms (-2.6%)

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD marked this pull request as ready for review June 5, 2025 21:32
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD requested a review from a team as a code owner June 5, 2025 21:32
@PerfectSlayer PerfectSlayer merged commit d26448e into master Jun 6, 2025
511 of 512 checks passed
@PerfectSlayer PerfectSlayer deleted the alexeyk/fixed-oom branch June 6, 2025 07:46
@github-actions github-actions bot added this to the 1.50.0 milestone Jun 6, 2025
sezen-datadog pushed a commit that referenced this pull request Jun 6, 2025
@AlexeyKuznetsov-DD @sezen-datadog
Fixed OOM in lettuce-4 tests (#8935)
1dde42a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarziali amarziali amarziali approved these changes

@PerfectSlayer PerfectSlayer Awaiting requested review from PerfectSlayer

Assignees

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD

Labels
comp: testing Testing tag: no release notes Changes to exclude from release notes type: bug
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexeyKuznetsov-DD @amarziali @PerfectSlayer