-
Notifications
You must be signed in to change notification settings - Fork 306
Fix flaky Gradle Daemon instrumentation smoke test #8955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nikita-tkachenko-datadog
merged 3 commits into
master
from
nikita-tkachenko/gradle-plugin-smoke-test-flaky-fix
Jun 10, 2025
Merged
Fix flaky Gradle Daemon instrumentation smoke test #8955
nikita-tkachenko-datadog
merged 3 commits into
master
from
nikita-tkachenko/gradle-plugin-smoke-test-flaky-fix
Jun 10, 2025
+12
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 13 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~af4a98d9e1, baseline=1.50.0-SNAPSHOT~7787af738f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.023 s) : 0, 1023002
Total [baseline] (8.515 s) : 0, 8514952
Agent [candidate] (1.025 s) : 0, 1024591
Total [candidate] (8.561 s) : 0, 8561332
section iast
Agent [baseline] (1.151 s) : 0, 1150981
Total [baseline] (9.148 s) : 0, 9148127
Agent [candidate] (1.151 s) : 0, 1150966
Total [candidate] (9.159 s) : 0, 9159101
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.158 s) : 0, 1158276
Total [baseline] (9.171 s) : 0, 9170847
Agent [candidate] (1.152 s) : 0, 1152420
Total [candidate] (9.114 s) : 0, 9113520
section iast_TELEMETRY_OFF
Agent [baseline] (1.15 s) : 0, 1149932
Total [baseline] (9.184 s) : 0, 9184261
Agent [candidate] (1.158 s) : 0, 1158292
Total [candidate] (9.201 s) : 0, 9200677
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~af4a98d9e1, baseline=1.50.0-SNAPSHOT~7787af738f
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.159 ms) : 0, 683159
BytebuddyAgent [candidate] (684.037 ms) : 0, 684037
GlobalTracer [baseline] (239.497 ms) : 0, 239497
GlobalTracer [candidate] (242.018 ms) : 0, 242018
AppSec [baseline] (56.979 ms) : 0, 56979
AppSec [candidate] (56.671 ms) : 0, 56671
Debugger [baseline] (6.207 ms) : 0, 6207
Debugger [candidate] (6.218 ms) : 0, 6218
Remote Config [baseline] (733.225 µs) : 0, 733
Remote Config [candidate] (747.517 µs) : 0, 748
Telemetry [baseline] (12.854 ms) : 0, 12854
Telemetry [candidate] (11.333 ms) : 0, 11333
section iast
BytebuddyAgent [baseline] (802.507 ms) : 0, 802507
BytebuddyAgent [candidate] (802.958 ms) : 0, 802958
GlobalTracer [baseline] (230.665 ms) : 0, 230665
GlobalTracer [candidate] (231.093 ms) : 0, 231093
IAST [baseline] (25.416 ms) : 0, 25416
IAST [candidate] (26.88 ms) : 0, 26880
AppSec [baseline] (54.208 ms) : 0, 54208
AppSec [candidate] (52.123 ms) : 0, 52123
Debugger [baseline] (6.019 ms) : 0, 6019
Debugger [candidate] (5.901 ms) : 0, 5901
Remote Config [baseline] (599.148 µs) : 0, 599
Remote Config [candidate] (601.29 µs) : 0, 601
Telemetry [baseline] (7.942 ms) : 0, 7942
Telemetry [candidate] (7.916 ms) : 0, 7916
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (807.711 ms) : 0, 807711
BytebuddyAgent [candidate] (803.197 ms) : 0, 803197
GlobalTracer [baseline] (231.928 ms) : 0, 231928
GlobalTracer [candidate] (231.263 ms) : 0, 231263
IAST [baseline] (27.539 ms) : 0, 27539
IAST [candidate] (25.58 ms) : 0, 25580
AppSec [baseline] (52.102 ms) : 0, 52102
AppSec [candidate] (54.209 ms) : 0, 54209
Debugger [baseline] (5.998 ms) : 0, 5998
Debugger [candidate] (5.992 ms) : 0, 5992
Remote Config [baseline] (598.07 µs) : 0, 598
Remote Config [candidate] (602.904 µs) : 0, 603
Telemetry [baseline] (7.973 ms) : 0, 7973
Telemetry [candidate] (7.972 ms) : 0, 7972
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (800.883 ms) : 0, 800883
BytebuddyAgent [candidate] (807.381 ms) : 0, 807381
GlobalTracer [baseline] (231.515 ms) : 0, 231515
GlobalTracer [candidate] (233.054 ms) : 0, 233054
IAST [baseline] (27.437 ms) : 0, 27437
IAST [candidate] (28.915 ms) : 0, 28915
AppSec [baseline] (52.061 ms) : 0, 52061
AppSec [candidate] (50.689 ms) : 0, 50689
Debugger [baseline] (6.021 ms) : 0, 6021
Debugger [candidate] (6.013 ms) : 0, 6013
Remote Config [baseline] (590.462 µs) : 0, 590
Remote Config [candidate] (602.421 µs) : 0, 602
Telemetry [baseline] (7.86 ms) : 0, 7860
Telemetry [candidate] (7.921 ms) : 0, 7921
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~af4a98d9e1, baseline=1.50.0-SNAPSHOT~7787af738f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.032 s) : 0, 1031767
Total [baseline] (11.169 s) : 0, 11168864
Agent [candidate] (1.03 s) : 0, 1029566
Total [candidate] (11.113 s) : 0, 11112806
section appsec
Agent [baseline] (1.167 s) : 0, 1166631
Total [baseline] (11.179 s) : 0, 11179033
Agent [candidate] (1.168 s) : 0, 1168318
Total [candidate] (11.221 s) : 0, 11221449
section iast
Agent [baseline] (1.175 s) : 0, 1175426
Total [baseline] (11.339 s) : 0, 11338586
Agent [candidate] (1.173 s) : 0, 1172858
Total [candidate] (11.374 s) : 0, 11373534
section profiling
Agent [baseline] (1.273 s) : 0, 1272634
Total [baseline] (11.446 s) : 0, 11446185
Agent [candidate] (1.27 s) : 0, 1270301
Total [candidate] (11.465 s) : 0, 11465405
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~af4a98d9e1, baseline=1.50.0-SNAPSHOT~7787af738f
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.943 ms) : 0, 688943
BytebuddyAgent [candidate] (688.361 ms) : 0, 688361
GlobalTracer [baseline] (241.738 ms) : 0, 241738
GlobalTracer [candidate] (242.242 ms) : 0, 242242
AppSec [baseline] (56.005 ms) : 0, 56005
AppSec [candidate] (57.746 ms) : 0, 57746
Debugger [baseline] (6.219 ms) : 0, 6219
Debugger [candidate] (6.129 ms) : 0, 6129
Remote Config [baseline] (737.595 µs) : 0, 738
Remote Config [candidate] (721.191 µs) : 0, 721
Telemetry [baseline] (14.357 ms) : 0, 14357
Telemetry [candidate] (10.503 ms) : 0, 10503
section appsec
BytebuddyAgent [baseline] (703.54 ms) : 0, 703540
BytebuddyAgent [candidate] (704.139 ms) : 0, 704139
GlobalTracer [baseline] (238.532 ms) : 0, 238532
GlobalTracer [candidate] (238.971 ms) : 0, 238971
IAST [baseline] (21.862 ms) : 0, 21862
IAST [candidate] (21.968 ms) : 0, 21968
AppSec [baseline] (175.96 ms) : 0, 175960
AppSec [candidate] (176.596 ms) : 0, 176596
Debugger [baseline] (5.969 ms) : 0, 5969
Debugger [candidate] (5.967 ms) : 0, 5967
Remote Config [baseline] (637.57 µs) : 0, 638
Remote Config [candidate] (620.986 µs) : 0, 621
Telemetry [baseline] (7.395 ms) : 0, 7395
Telemetry [candidate] (7.394 ms) : 0, 7394
section iast
BytebuddyAgent [baseline] (820.472 ms) : 0, 820472
BytebuddyAgent [candidate] (818.547 ms) : 0, 818547
GlobalTracer [baseline] (235.017 ms) : 0, 235017
GlobalTracer [candidate] (234.333 ms) : 0, 234333
IAST [baseline] (26.087 ms) : 0, 26087
IAST [candidate] (28.334 ms) : 0, 28334
AppSec [baseline] (55.158 ms) : 0, 55158
AppSec [candidate] (52.916 ms) : 0, 52916
Debugger [baseline] (6.021 ms) : 0, 6021
Debugger [candidate] (6.038 ms) : 0, 6038
Remote Config [baseline] (621.643 µs) : 0, 622
Remote Config [candidate] (612.841 µs) : 0, 613
Telemetry [baseline] (8.02 ms) : 0, 8020
Telemetry [candidate] (8.125 ms) : 0, 8125
section profiling
BytebuddyAgent [baseline] (679.256 ms) : 0, 679256
BytebuddyAgent [candidate] (679.449 ms) : 0, 679449
GlobalTracer [baseline] (361.452 ms) : 0, 361452
GlobalTracer [candidate] (360.49 ms) : 0, 360490
AppSec [baseline] (61.879 ms) : 0, 61879
AppSec [candidate] (61.46 ms) : 0, 61460
Debugger [baseline] (6.156 ms) : 0, 6156
Debugger [candidate] (6.045 ms) : 0, 6045
Remote Config [baseline] (690.694 µs) : 0, 691
Remote Config [candidate] (664.053 µs) : 0, 664
Telemetry [baseline] (8.244 ms) : 0, 8244
Telemetry [candidate] (8.07 ms) : 0, 8070
ProfilingAgent [baseline] (103.919 ms) : 0, 103919
ProfilingAgent [candidate] (102.847 ms) : 0, 102847
Profiling [baseline] (103.944 ms) : 0, 103944
Profiling [candidate] (102.87 ms) : 0, 102870
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 5 performance regressions! Performance is the same for 0 metrics, 9 unstable metrics.
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~af4a98d9e1, baseline=1.50.0-SNAPSHOT~7787af738f
dateFormat X
axisFormat %s
section baseline
no_agent (15.099 s) : 15099000, 15099000
. : milestone, 15099000,
appsec (14.832 s) : 14832000, 14832000
. : milestone, 14832000,
iast (18.488 s) : 18488000, 18488000
. : milestone, 18488000,
iast_GLOBAL (18.203 s) : 18203000, 18203000
. : milestone, 18203000,
profiling (15.301 s) : 15301000, 15301000
. : milestone, 15301000,
tracing (14.8 s) : 14800000, 14800000
. : milestone, 14800000,
section candidate
no_agent (15.26 s) : 15260000, 15260000
. : milestone, 15260000,
appsec (14.916 s) : 14916000, 14916000
. : milestone, 14916000,
iast (18.581 s) : 18581000, 18581000
. : milestone, 18581000,
iast_GLOBAL (17.848 s) : 17848000, 17848000
. : milestone, 17848000,
profiling (15.15 s) : 15150000, 15150000
. : milestone, 15150000,
tracing (14.848 s) : 14848000, 14848000
. : milestone, 14848000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~af4a98d9e1, baseline=1.50.0-SNAPSHOT~7787af738f
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (2.404 ms) : 2355, 2453
. : milestone, 2404,
iast (2.198 ms) : 2136, 2259
. : milestone, 2198,
iast_GLOBAL (2.228 ms) : 2166, 2289
. : milestone, 2228,
profiling (2.056 ms) : 2004, 2107
. : milestone, 2056,
tracing (2.001 ms) : 1953, 2049
. : milestone, 2001,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (2.401 ms) : 2352, 2450
. : milestone, 2401,
iast (2.184 ms) : 2123, 2246
. : milestone, 2184,
iast_GLOBAL (2.233 ms) : 2171, 2295
. : milestone, 2233,
profiling (2.048 ms) : 1998, 2098
. : milestone, 2048,
tracing (2.018 ms) : 1970, 2066
. : milestone, 2018,
|
AlexeyKuznetsov-DD
requested changes
Jun 10, 2025
dd-smoke-tests/gradle/src/test/groovy/datadog/smoketest/GradleDaemonSmokeTest.groovy
Outdated
Show resolved
Hide resolved
dd-smoke-tests/gradle/src/test/resources/test-succeed-gradle-plugin-test/events.ftl
Show resolved
Hide resolved
dd-smoke-tests/gradle/src/test/resources/test-succeed-gradle-plugin-test/coverages.ftl
Show resolved
Hide resolved
AlexeyKuznetsov-DD
requested changes
Jun 10, 2025
dd-smoke-tests/gradle/src/test/groovy/datadog/smoketest/GradleDaemonSmokeTest.groovy
Show resolved
Hide resolved
bric3
approved these changes
Jun 10, 2025
dd-smoke-tests/gradle/src/test/groovy/datadog/smoketest/GradleDaemonSmokeTest.groovy
Show resolved
Hide resolved
AlexeyKuznetsov-DD
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: ci visibility
Continuous Integration Visibility
comp: testing
Testing
tag: no release notes
Changes to exclude from release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Fixes flaky Gradle Daemon instrumentation test:
test-succeed-gradle-plugin-test
.Motivation
This test case is different from the others because the instrumented project builds a Gradle plugin and uses Gradle Test Kit to test it.
There was an issue where our Gradle Launcher instrumentation interfered with Gradle Test Kit, and this test case was added to ensure the issue does not reappear.
The test inside the instrumented project runs a Gradle build. So we have three nested Gradle builds:
If the Gradle version used by Gradle Test Kit is not available locally, the test kit downloads it.
These Gradle downloads sometimes fail.
In the case of this flaky test the download that fails is of the Gradle distribution needed to run the "innermost" build.
In the smoke test itself ("middle" nested build) we solve it by having a custom download logic with extended timeout and retries.
The fix is to update the test inside the sample project to use the same Gradle version that is used to run the project itself (Gradle version is propagated from the smoke test with an env var).
As that Gradle distribution is already available locally, the test will not try to redownload it.
N.B. All downloads are stored under
~/.gradle/wrapper/
.Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]