Skip to content

ci: build cp27 with older manylinux #2137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 9, 2021
Merged

Conversation

majorgreys
Copy link
Contributor

@majorgreys majorgreys commented Mar 9, 2021

CPython2.7 was dropped recently in manylinux2010. We should use the last tag with support to continue building wheel for 2.7 for our wheelhouse (see pypa/manylinux#428 (comment)).

@majorgreys majorgreys requested a review from a team as a code owner March 9, 2021 18:27
@majorgreys majorgreys added automerge changelog/no-changelog A changelog entry is not required for this PR. labels Mar 9, 2021
@majorgreys majorgreys changed the title ci: pin manylinux for mkwheelhouse ci: build cp27 with older manylinux Mar 9, 2021
Copy link
Member

@Kyle-Verhoog Kyle-Verhoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM - just one suggestion for a comment

@mergify mergify bot merged commit 3722c36 into DataDog:master Mar 9, 2021
@majorgreys majorgreys deleted the pin-manylinux branch March 10, 2021 02:18
majorgreys added a commit to majorgreys/dd-trace-py that referenced this pull request May 13, 2021
* ci: build cp27 with older manylinux

* Update scripts/mkwheelhouse

Co-authored-by: Kyle Verhoog <[email protected]>

Co-authored-by: Kyle Verhoog <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants