[ECOINT-212] Redpanda v2.1.0 - Support for lag metrics #2719
Conversation
The tests now pass. Signed-off-by: Ben Pope <[email protected]>
As of Redpanda v25.1, some consumer group metrics can be disabled by changing cluster config "enable_consumer_group_metrics". These are still enabled by default, but split them out into their own grouping. Signed-off-by: Ben Pope <[email protected]>
Signed-off-by: Ben Pope <[email protected]>
Signed-off-by: Ben Pope <[email protected]>
…deprecating the older offset metrics
Signed-off-by: Paul Wilkinson <[email protected]>
Signed-off-by: Ben Pope <[email protected]>
dd-dominic
changed the title
There was a problem hiding this comment.
My recommendation is to add these 4 widgets to the current dashboard (using a separate grouping widget). Once merged, these changes will be reflected in the original dashboards for existing customer installations.
If you'd like to keep this second dashboard, that's fine too.
In either case, the dashboard(s) will need to be brought inline with our best practices. See attached dashboard template.
Integration_Dashboard_Template.json
There was a problem hiding this comment.
Where can we find documentation on the dashboard best practices? Is this json template the only description of this?
There was a problem hiding this comment.
@hcoyote, I've found the best practice guides and have started reorganising the dashboards accordingly.
@dd-dominic, thanks for the recommendation, but I think we'd prefer to not have them in the main dashboard:
Firstly, there's a somewhat different audience for the lag metrics (Redpanda users interested in how their applications are behaving) vs the rest of the metrics (Redpanda administrators interested in how the cluster as a whole is behaving).
Secondly, the lag metrics are optional on the Redpanda side, and are only emitted once RP is configured to do so - so having them not show in the default dashboard feels off.
There was a problem hiding this comment.
Understood, makes sense. Just make sure to update both dashboards to mirror our template as much as possible (colored group headings, branding/image, title casing, etc.)
There was a problem hiding this comment.
Done. It would be lovely to be able to specify our own branding colours via a hex code though 👍
temporal-github-worker-1
bot
added
agent/requested-changes
and removed
agent/review-requested
labels
…to account for the change.
temporal-github-worker-1
bot
added
agent/approved
and removed
agent/requested-changes
labels
What does this PR do?
This adds support to the Redpanda integration for native lag metrics.
Motivation
New feature availability within Redpanda.
Review checklist
no-changeloglabel attachedAdditional Notes
Anything else we should know when reviewing?