Correct the dev dependency table PEP 735 #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joasode
changed the title
joasode
force-pushed
the
correct-dependency-table
branch
from
f8604fe to
e2e6ed4
Compare
Chroxvi
requested changes
Mar 21, 2025
Co-authored-by: Christian Schou Oxvig <[email protected]>
joasode
commented
Mar 21, 2025
joasode
changed the title
Chroxvi
requested changes
Mar 21, 2025
Chroxvi
previously approved these changes
Mar 21, 2025
This was referenced Mar 24, 2025
TheBlackKoala
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was trying to properly use the
uv syncI had trouble to include the optional dependencies. This PR properly changes the label todependency-groupswhich is the correct way to include developer dependencies according to PEP735. For discussion on differences between dependency-groups and optional-dependencies see this issue.Turns out
uvsupport for PEP735 was released faster than forpip. It is merged into main in the pip repository but does not currently seem to be released. We could change this PR to do the following solution or just update all the CI use uv and ignore the quick loss ofpip install -e .[dev]notation.