Pull config via @ConfigProperty in mirror-service
#1236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nscuro
changed the title
nscuro
changed the title
@ConfigProperty in mirror-service
nscuro
force-pushed
the
use-config-extension-mirrorsvc
branch
5 times, most recently
from
24aac5f to
2071526
Compare
nscuro
force-pushed
the
use-config-extension-mirrorsvc
branch
7 times, most recently
from
23409aa to
e6859ac
Compare
Also removes manual retry logic, as the `open-vulnerability-clients` library has added its own retry since we originally adopted it. Further removed the `num-threads` configuration option for the NVD datasource. Downloading of the data has never been a bottleneck, it's always the processing of already downloaded data that's the most time-consuming. Signed-off-by: nscuro <[email protected]>
Even though the container will do effectively nothing, this at least verifies it's starting as intended. Signed-off-by: nscuro <[email protected]>
nscuro
force-pushed
the
use-config-extension-mirrorsvc
branch
from
4f73631 to
197a966
Compare
Signed-off-by: nscuro <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note
This PR is based on #1223. Please review that first, I'll update this PR once it is merged. Should drastically reduce the change size. :)Replaces properties pulled from
application.properties/ environment variables to configure datasources in mirror-service, with properties from theCONFIGPROPERTYdatabase table. This is achieved via thequarkus-config-dependencytrackextension introduced in #1223.Addressed Issue
Relates to #929
Additional Details
Checklist
This PR fixes a defect, and I have provided tests to verify that the fix is effectiveThis PR introduces changes to the database model, and I have updated the migration changelog accordinglyThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly