Skip to content

Enable logging in modules #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

winterheart
Copy link
Collaborator

Pull Request Type

  • GitHub Workflow changes
  • Documentation or Wiki changes
  • Build and Dependency changes
  • Runtime changes
    • Render changes
    • Audio changes
    • Input changes
    • Network changes
    • Other changes

Description

This PR enables logging with plog in shared modules (netcon and netgames). Previously used DLLmprintf() was no-op.
For each module added new function for initialization and accessing to main logger instance.

Related Issues

Screenshots (if applicable)

Checklist

  • I have tested my changes locally and verified that they work as intended.
  • I have documented any new or modified functionality.
  • I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

Copy link
Member

@Lgt2x Lgt2x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! There are a few DLLmprintf calls remaining, mostly in chat_api.cpp and mt_net.cpp, maybe they should be converted to LOG_SOMETHING as well?

I'll also test on Windows when I'll be on my desktop, you never know what it can do with DLLs.

Implementing chained appender initialization scenario for plog.
Implementing chained appender initialization scenario for plog.
@winterheart
Copy link
Collaborator Author

Additional mprintf() replacing that found in second run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants