Skip to content

Formatting for .props files #187

Closed
Closed
@TheAifam5

Description

@TheAifam5

Description

What seems to be the problem?
It's seems like after the update from 2.1.1, the formatter does not format the .props files propertly. Also looks like the Classic formatter does not respect the spacing settings.

Formatter Implementation

Which XML Formatter implementation are you using (the value of your xmlTools.xmlFormatterImplementation setting).
Both.

XML Tools Version

What version of XML Tools are you using?
2.2.0

VS Code Version

What version of VS Code are you using?
Version 1.23.1
Commit d0182c3417d225529c6d5ad24b7572815d0de9ac
Date 2018-05-10T17:11:17.614Z
Shell 1.7.12
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

Operating System

What OS (and version) are you using?
Windows 10 x64

Example (Spaces 2):

Content:
<Project>
  <PropertyGroup>
    <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
    <LangVersion>latest</LangVersion>
  </PropertyGroup>
  <PropertyGroup Condition=" '$(Configuration)'=='Release' ">
    <DebugSymbols>false</DebugSymbols>
    <DebugType>None</DebugType>
    <Optimize>true</Optimize>
  </PropertyGroup>
  <ItemGroup Condition=" '$(Configuration)'=='Release' ">
    <Content Remove="appsettings.Development.json" />
  </ItemGroup>
  <ItemGroup Condition=" '$(Configuration)'=='Debug' ">
    <Content Remove="appsettings.Production.json" />
  </ItemGroup>
</Project>
V2 formatter implementation:
<Project>
  <PropertyGroup>
    <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
<LangVersion>latest</LangVersion>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)'=='Release' ">
      <DebugSymbols>false</DebugSymbols>
      <DebugType>None</DebugType>
      <Optimize>true</Optimize>
    </PropertyGroup>
    <ItemGroup Condition=" '$(Configuration)'=='Release' ">
      <Content Remove="appsettings.Development.json" />
    </ItemGroup>
    <ItemGroup Condition=" '$(Configuration)'=='Debug' ">
      <Content Remove="appsettings.Production.json" />
    </ItemGroup>
  </Project>
Classic formatter implementation (have in mind the empty first line):

<Project>
	<PropertyGroup>
		<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
		<LangVersion>latest</LangVersion>
	</PropertyGroup>
	<PropertyGroup Condition=" '$(Configuration)'=='Release' ">
		<DebugSymbols>false</DebugSymbols>
		<DebugType>None</DebugType>
		<Optimize>true</Optimize>
	</PropertyGroup>
	<ItemGroup Condition=" '$(Configuration)'=='Release' ">
		<Content Remove="appsettings.Development.json" />
	</ItemGroup>
	<ItemGroup Condition=" '$(Configuration)'=='Debug' ">
		<Content Remove="appsettings.Production.json" />
	</ItemGroup>
</Project>

Example 2 (Spaces 2):

Content:
<Project>
  <PropertyGroup>
    <DotNetSdkVersion>netstandard2.1</DotNetSdkVersion>
    <DotNetWebSdkVersion>netcoreapp2.1</DotNetWebSdkVersion>

    <NewtonsoftJsonVersion>11.0.2</NewtonsoftJsonVersion>
    <DotNetAnnotationsVersion>4.4.1</DotNetAnnotationsVersion>

    <AspNetCoreVersion>2.0.3</AspNetCoreVersion>
    <AspNetCoreMvcVersion>2.0.4</AspNetCoreMvcVersion>
    <AspNetCoreMvcVersioningVersion>2.2.0</AspNetCoreMvcVersioningVersion>
    <AspNetCoreExtensionsVersion>2.0.2</AspNetCoreExtensionsVersion>

    <IdentityServer4Version>2.2.0</IdentityServer4Version>
    <IdentityServer4TokenValidationVersion>2.6.0</IdentityServer4TokenValidationVersion>
    <IdentityServer4AspIdentityVersion>2.1.0</IdentityServer4AspIdentityVersion>
    <IdentityServer4EntityFrameworkVersion>2.1.1</IdentityServer4EntityFrameworkVersion>

    <AutoMapperVersion>6.2.2</AutoMapperVersion>
    <AutoMapperExtensionsVersion>3.2.0</AutoMapperExtensionsVersion>
    <AutoMapperCollectionsVersion>3.1.3</AutoMapperCollectionsVersion>
    <ZEntityFrameworkVersion>1.7.20</ZEntityFrameworkVersion>

    <DocumentFormatOpenXMLVersion>2.8.1</DocumentFormatOpenXMLVersion>
  </PropertyGroup>
</Project>
V2 formatter implementation:
<Project>
  <PropertyGroup>
    <DotNetSdkVersion>netstandard2.1</DotNetSdkVersion>
    <DotNetWebSdkVersion>netcoreapp2.1</DotNetWebSdkVersion>

    <NewtonsoftJsonVersion>11.0.2</NewtonsoftJsonVersion>
    <DotNetAnnotationsVersion>4.4.1</DotNetAnnotationsVersion>

    <AspNetCoreVersion>2.0.3</AspNetCoreVersion>
    <AspNetCoreMvcVersion>2.0.4</AspNetCoreMvcVersion>
    <AspNetCoreMvcVersioningVersion>2.2.0</AspNetCoreMvcVersioningVersion>
    <AspNetCoreExtensionsVersion>2.0.2</AspNetCoreExtensionsVersion>

    <IdentityServer4Version>2.2.0</IdentityServer4Version>
    <IdentityServer4TokenValidationVersion>2.6.0</IdentityServer4TokenValidationVersion>
    <IdentityServer4AspIdentityVersion>2.1.0</IdentityServer4AspIdentityVersion>
    <IdentityServer4EntityFrameworkVersion>2.1.1</IdentityServer4EntityFrameworkVersion>

    <AutoMapperVersion>6.2.2</AutoMapperVersion>
    <AutoMapperExtensionsVersion>3.2.0</AutoMapperExtensionsVersion>
    <AutoMapperCollectionsVersion>3.1.3</AutoMapperCollectionsVersion>
    <ZEntityFrameworkVersion>1.7.20</ZEntityFrameworkVersion>

    <DocumentFormatOpenXMLVersion>2.8.1</DocumentFormatOpenXMLVersion>
  </PropertyGroup>
</Project>
Classic formatter implementation (have in mind the empty first line):

<Project>
	<PropertyGroup>
		<DotNetSdkVersion>netstandard2.1</DotNetSdkVersion>
		<DotNetWebSdkVersion>netcoreapp2.1</DotNetWebSdkVersion>
		<NewtonsoftJsonVersion>11.0.2</NewtonsoftJsonVersion>
		<DotNetAnnotationsVersion>4.4.1</DotNetAnnotationsVersion>
		<AspNetCoreVersion>2.0.3</AspNetCoreVersion>
		<AspNetCoreMvcVersion>2.0.4</AspNetCoreMvcVersion>
		<AspNetCoreMvcVersioningVersion>2.2.0</AspNetCoreMvcVersioningVersion>
		<AspNetCoreExtensionsVersion>2.0.2</AspNetCoreExtensionsVersion>
		<IdentityServer4Version>2.2.0</IdentityServer4Version>
		<IdentityServer4TokenValidationVersion>2.6.0</IdentityServer4TokenValidationVersion>
		<IdentityServer4AspIdentityVersion>2.1.0</IdentityServer4AspIdentityVersion>
		<IdentityServer4EntityFrameworkVersion>2.1.1</IdentityServer4EntityFrameworkVersion>
		<AutoMapperVersion>6.2.2</AutoMapperVersion>
		<AutoMapperExtensionsVersion>3.2.0</AutoMapperExtensionsVersion>
		<AutoMapperCollectionsVersion>3.1.3</AutoMapperCollectionsVersion>
		<ZEntityFrameworkVersion>1.7.20</ZEntityFrameworkVersion>
		<DocumentFormatOpenXMLVersion>2.8.1</DocumentFormatOpenXMLVersion>
	</PropertyGroup>
</Project>

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions