Fix misalignment between AdvancedSettings defaults and VCRHandler constructor #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
VCRHandler
is created with a nullAdvancedSettings
, or anAdvancedSettings
with a nullMatchRules
property, then the handler_matchRules
is set to a new instance ofMatchRules
.However, when
AdvancedSettings
is instanciated, it usesMatchRules.Default
by default for itsMatchRules
property.As passing no
AdvancedSettings
is expected to behave exactly like passing a defaultAdvancedSettings
instance, this creates a bug, where if noAdvancedSettings
is provided, all requests are matching by default.Testing
1 Unit tests has been updated, and another has been created to confirm the bug and the fix.
Pull Request Type
Please select the option(s) that are relevant to this PR.