Toll-calculator update suggestion #84
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sier to navigate application. Added unitstest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
Heres my little update to the toll-calculator.
I tried simplifying and separating some of the logic of the calculator to make it easier to read and navigate.
I've added a project with unit tests to make sure that the application performs it's expected tasks even after further changes.
An assumtion I have while doing the changes was - The description of "Weekends and holidays are fee-free" I assumed to be bank holidays.
I've left some comments around the solution, which i wouldn't have if this was not a basis for discussion.
Kind regards
Oscar Berntsson