Skip to content

CharSequence variant of JsonStringEncoder.quoteAsString #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 30, 2016
Merged

CharSequence variant of JsonStringEncoder.quoteAsString #266

merged 3 commits into from
Mar 30, 2016

Conversation

mikaelstaldal
Copy link
Contributor

Fix for #265

cowtowncoder
cowtowncoder reviewed Mar 26, 2016
View reviewed changes
src/test/java/com/fasterxml/jackson/core/io/TestJsonStringEncoder.java
@@ -37,7 +50,24 @@ public void testQuoteLongAsString() throws Exception
assertEquals(exp, new String(result));

}


// For [JACKSON-853]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this, or change to point to [core#266](or whatever was id of the issue)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@cowtowncoder
Copy link
Member

Looks good, and I'd be happy to merge it in. The only thing before that is to make sure I have an CLA for you -- I don't think I've asked for one yet?

You can find the doc at:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and the usual thing to do is to print, fill & sign, scan and email it to info at fasterxml dot com.
If you could do that, I can merge the PR as soon as I have it. Also, this is one time thing: further merges are fine for any and all Jackson projects. Apologies for having to do this, but it's the minimum we need from process perspective (some companies are very strict on ensuring OSS libs they use make sure to get confirmation that all contributions are valid etc).

@cowtowncoder cowtowncoder added this to the 2.8.0 milestone Mar 30, 2016
@cowtowncoder
Copy link
Member

Looks good, got CLA, merging.

@cowtowncoder cowtowncoder merged commit a1a0282 into FasterXML:master Mar 30, 2016
@cowtowncoder cowtowncoder mentioned this pull request Mar 30, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mikaelstaldal @cowtowncoder