Fix(FlowiseChatGoogleGenerativeAI): 400 Bad Request errors from Gemini API when converting tool schemas - MCP tools. #4294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenryHengZJ
approved these changes
Apr 14, 2025
Yshayy
pushed a commit
to Yshayy/Flowise
that referenced
this pull request
Apr 23, 2025
…i API when converting tool schemas - MCP tools. (FlowiseAI#4294) * fix: 400 Bad Request errors from Gemini API when converting tool schemas (MCP tools). * Update FlowiseChatGoogleGenerativeAI.ts --------- Co-authored-by: Henry Heng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR fixes the 400 Bad Request errors when using function calling with Gemini API when MCP tools are used. The main issue was that some properties in the tool schemas were missing explicit type definitions when converting from Zod schemas to Gemini's function declarations format.
Changes
zodToGeminiParametersfunction to properly infer typesBreaking Changes
None. This is a backward compatible enhancement to the existing functionality.