Fix: Default vision model overriding custom model name for AWS Chat Bedrock. #4309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yshayy
pushed a commit
to Yshayy/Flowise
that referenced
this pull request
Apr 23, 2025
…edrock. (FlowiseAI#4309) fix condition to not default to claude haiku when custom model name is provided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes this bug.
Bedrock requires the use of an inference profile when making on-demand API requests to Claude sonnet. The inference profile is in the form
<region>.<model name and version>, i.e.us.anthropic.claude-3-7-sonnet-20250219-v1:0. The inference profile ID needs to be set as theCustom Model Nameattribute for the AWS ChatBedrock node in order to override the default model name.The existing code incorrectly sets the vision model to default to
anthropic.claude-3-haiku-20240307-v1:0when an inference profile ID is set as theCustom Model Name. For example, setting custom model nameus.anthropic.claude-3-7-sonnet-20250219-v1:0will cause the vision model to default to haiku because the custom model name does not start withclaude-3.The proposed fix checks that the model name includes the string
claude-3, which would allow the custom model name to be used as the vision model.