Skip to content

Better Error reporting for document store operations. #4350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vinodkiran
Copy link
Contributor

No description provided.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances error reporting for document store operations by improving error message consistency and behavior across both the UI and server layers. Key changes include correcting a spelling mistake in the UI error text; adding additional styling to error details; and refactoring catch blocks in server services to remove redundant error prefixes and provide consistent error propagation.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/ui/src/ErrorBoundary.jsx Fixes a spelling mistake and adds additional styling to the error details presentation.
packages/server/src/services/documentstore/index.ts Refactors error handling in catch blocks by removing redundant prefixes and ensuring internal errors are rethrown consistently.
Comments suppressed due to low confidence (1)

packages/server/src/services/documentstore/index.ts:64

  • [nitpick] Removing the static service name prefix from the error message improves clarity, but please verify that getErrorMessage provides sufficient context for debugging purposes.
throw new InternalFlowiseError(StatusCodes.INTERNAL_SERVER_ERROR, `${getErrorMessage(error)}`)

@vinodkiran vinodkiran requested a review from Copilot April 26, 2025 15:56
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the error reporting for document store operations by standardizing error messages and adjusting error-handling logic while also fixing a typo in the UI component.

  • Corrects a spelling mistake in the error message on the UI side.
  • Simplifies error messages in server-side document store service functions.
  • Introduces conditional rethrowing of InternalFlowiseError instances in most service functions to avoid double-wrapping errors.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/ui/src/ErrorBoundary.jsx Fixed a typo and improved the styling for error display.
packages/server/src/services/documentstore/index.ts Simplified error messages and standardized error handling across various functions.

@HenryHengZJ HenryHengZJ merged commit ddeb591 into FlowiseAI:main Apr 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants