Skip to content

bugfix/Fix SQL syntax error when reverting migration in MariaDB #4565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 5, 2025
Merged

bugfix/Fix SQL syntax error when reverting migration in MariaDB #4565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
520e0bb
Bugfix/Use backticks when dropping `errors` column for MariaDB compat…
ejrtks1020 Jun 3, 2025
e9968f2
Bugfix/Use backticks when dropping `sequence_no` column for MariaDB c…
ejrtks1020 Jun 3, 2025
34c7d66
Bugfix/Use backticks when dropping sso columns for MariaDB compatibil…
ejrtks1020 Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/server/src/database/migrations/mariadb/1733752119696-AddSeqNoToDatasetRow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ export class AddSeqNoToDatasetRow1733752119696 implements MigrationInterface {
}

public async down(queryRunner: QueryRunner): Promise<void> {
await queryRunner.query(`ALTER TABLE "dataset_row" DROP COLUMN "sequence_no";`)
await queryRunner.query(`ALTER TABLE \`dataset_row\` DROP COLUMN \`sequence_no\``)
}
}
2 changes: 1 addition & 1 deletion packages/server/src/database/migrations/mariadb/1744964560174-AddErrorToEvaluationRun.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ export class AddErrorToEvaluationRun1744964560174 implements MigrationInterface
}

public async down(queryRunner: QueryRunner): Promise<void> {
await queryRunner.query(`ALTER TABLE "evaluation_run" DROP COLUMN "errors";`)
await queryRunner.query(`ALTER TABLE \`evaluation_run\` DROP COLUMN \`errors\`;`)
}
}
6 changes: 3 additions & 3 deletions packages/server/src/enterprise/database/migrations/mariadb/1730519457880-AddSSOColumns.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ export class AddSSOColumns1730519457880 implements MigrationInterface {
}

public async down(queryRunner: QueryRunner): Promise<void> {
await queryRunner.query(`ALTER TABLE "organization" DROP COLUMN "sso_config";`)
await queryRunner.query(`ALTER TABLE "user" DROP COLUMN "user_type";`)
await queryRunner.query(`ALTER TABLE "login_activity" DROP COLUMN "login_mode";`)
await queryRunner.query(`ALTER TABLE \`organization\` DROP COLUMN \`sso_config\`;`)
await queryRunner.query(`ALTER TABLE \`user\` DROP COLUMN \`user_type\`;`)
await queryRunner.query(`ALTER TABLE \`login_activity\` DROP COLUMN \`login_mode\`;`)
}
}