#382 tweak dependencies based on new tfm

[thompson-tomo]

Closes #382

[CLAassistant]

All committers have signed the CLA.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[ejsmith]

dotnet/runtime#115124 (comment)

This seems to say that we should just add the additional target frameworks and leave the packagereferences alone.

[thompson-tomo]

So my reading of that issue is that recommendation only applies to bcl libraries & when the classes are exposed in public apis.

[ejsmith]

My understanding is that if we just add the other targets that the dependencies will just automatically go away on platforms where those dependencies are already included.

[thompson-tomo]

Not the case as they clearly mention the polyfil in particular the redirect which only happens due to library rename. Just look at what the Azure team has done with their libraries where they kept the bcl but not STJ. See their summary in Azure/azure-sdk-for-net#48977 (comment)

[ejsmith]

Hmm. I think we are going to need to run the tests on each platform to make sure we didn't break anything.

[niemyjski]

Hmm. I think we are going to need to run the tests on each platform to make sure we didn't break anything.

Are we expecting to update all projects to target both of these? I'm guessing so or should we just run on lowest (netstandard)? Ideally someday I'd like to bump the netstandard for NRT.

[thompson-tomo]

Yes expectation is that most if not all projects are bumped so that they follow the same TFM.

[Copilot]

Pull Request Overview

This PR updates package dependencies to account for a new net8.0 target framework and adjusts references conditionally based on TFM compatibility.

• Extracts certain PackageReference entries into conditional <ItemGroup> blocks for non-net6.0 targets.
• Moves System.Collections.Immutable in the Xunit project under a compatibility check.
• Adds net8.0 alongside netstandard2.0 in the shared TargetFrameworks list.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/Foundatio/Foundatio.csproj	Split core dependencies into TFM-specific <ItemGroup> blocks with comments
src/Foundatio.Xunit/Foundatio.Xunit.csproj	Wrapped System.Collections.Immutable in a TFM compatibility condition
build/common.props	Appended net8.0 to <TargetFrameworks>

[niemyjski]

Thanks for the PR. I'm going to fix up some of the new warnings and build pipeline so all TFMs run for tests