Storage Exception + FileSpec Data Prop #385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds a storage-specific exception type and enriches file metadata with a flexible Data dictionary, while making minor constructor and formatting adjustments.
- Introduce
StorageExceptionfor uniform error handling in storage operations - Extend
FileSpecto implementIHaveDataand populateDatain implementations - Refactor expression-bodied constructors and explicit type declarations for consistency
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Foundatio/Storage/StorageException.cs | New exception class to centralize storage errors |
| src/Foundatio/Storage/InMemoryFileStorage.cs | Expanded constructor block and changed var to byte[] for clarity |
| src/Foundatio/Storage/IFileStorage.cs | Updated FileSpec to implement IHaveData and added Data property |
| src/Foundatio/Storage/FolderFileStorage.cs | Populated Data with IsReadOnly and added empty Dispose block |
Comments suppressed due to low confidence (1)
src/Foundatio/Storage/InMemoryFileStorage.cs:40
- [nitpick] The empty block for the expression-bodied constructor is redundant—consider reverting to the original expression-bodied syntax for consistency with the rest of the codebase.
{
| @@ -84,7 +84,8 @@ public Task<FileSpec> GetFileInfoAsync(string path) | |||
| Path = normalizedPath.Replace(Folder, String.Empty), | |||
| Created = info.CreationTimeUtc, | |||
| Modified = info.LastWriteTimeUtc, | |||
| Size = info.Length | |||
| Size = info.Length, | |||
| Data = { { "IsReadOnly", info.IsReadOnly } } | |||
There was a problem hiding this comment.
This initialization is duplicated at line 331; consider extracting Data population into a helper method or factory to reduce duplication and ease future extensions.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Guess we may need to type this as a data dictionary for extensions? And or just don't set this here.
ejsmith
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for FoundatioFx/Foundatio.AWS#305
Didn't really see any spots to use the exception in the base library but probably should investigate that more.