Skip to content

DE-901 - Support template creation #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 5, 2022

Conversation

andresmoschini
Copy link
Member

@andresmoschini andresmoschini commented Dec 5, 2022

Hi team!

These changes allow us to create templates based on another template.

Related to https://github.com/MakingSense/Doppler/pull/9883

There are some refactorings in this PR because I learn about TypedResults and I really liked them. In following steps I will be migrating all the API from IActionResult to typed IResult.

Could you review?

@andresmoschini
Copy link
Member Author

Metadata is not being used in Swagger UI:

image

But it is already detected (see here) and it will be probably fixed soon.

Copy link
Contributor

@Cromeror Cromeror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@andresmoschini andresmoschini merged commit 36a85df into main Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants