Skip to content

feat: various search improvements #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 22, 2025

Conversation

ajanvier
Copy link
Contributor

  • Use the current media type as search type per default (e.g. if we're in the Anime list, the search type is automatically set to Anime)
  • Make the media list search placeholder more distinct from the header search
  • Sort TMDB results (tv/movies) by popularity for more relevant results order

Copy link

codecov bot commented Mar 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.14%. Comparing base (0c46141) to head (c2310c4).
Report is 6 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #392   +/-   ##
=======================================
  Coverage   73.14%   73.14%           
=======================================
  Files         117      117           
  Lines        5876     5876           
=======================================
  Hits         4298     4298           
  Misses       1578     1578           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FuzzyGrim FuzzyGrim merged commit 0e02106 into FuzzyGrim:dev Mar 22, 2025
7 of 8 checks passed
@FuzzyGrim
Copy link
Owner

Thanks for the PR, on sorting TMDB results by popularity, which queries did you find it useful? I've tried a few and for example with “Friends” or "Chernobyl", it seems that the default relevance sort seems to do better.

@ajanvier
Copy link
Contributor Author

Thanks for the PR, on sorting TMDB results by popularity, which queries did you find it useful? I've tried a few and for example with “Friends” or "Chernobyl", it seems that the default relevance sort seems to do better.

I don't remember the exact shows I searched but I guess it's more of an API "issue" (to improve the results order) rather than something that can be handled in Yamtrack 😕

@ajanvier ajanvier deleted the feat/search-improvement branch May 1, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants