-
Notifications
You must be signed in to change notification settings - Fork 21
feat: add release calendar export #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add release calendar export #415
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #415 +/- ##
=======================================
Coverage 86.59% 86.59%
=======================================
Files 56 56
Lines 4730 4730
=======================================
Hits 4096 4096
Misses 634 634 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thanks! |
Would there be any problem in changing from all day events to time specific events with time zone information? I can implement the change, but I would like to know if there would be any possible problems that I haven't thought of. The current implementation creates day-long events using only the date component of release timestamps. This causes timezone discrepancies for users in different timezones, as UTC release times don't properly convert to the user's local date.
|
If you want to use time-specific events, as the icalendar library extracts the timezone info from tz-aware datetime (see docs), I would go with something like: dt_tz_aware = release.datetime.replace(tzinfo=timezone.utc)
cal_event.add("dtstart", dt_tz_aware)
cal_event.add("dtend", dt_tz_aware) The calendar client will see that the time is defined as UTC and should adapt it depending on the localtime or user settings. |
Export the release calendar through an iCal file that can be downloaded from the calendar page or accessed through a link also displayed on the calendar page (authenticated using the user's token).
Fixes #375