Skip to content

Property Reorder & Value Insert #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 22, 2020
Merged

Property Reorder & Value Insert #398

merged 11 commits into from
Jun 22, 2020

Conversation

fschrader1992
Copy link
Collaborator

This PR:

  • Enables the reordering of section properties.
  • Adds a method to insert a new property.value at a certain index.

@fschrader1992
[property.py] Add Reorder Method
57fd085 
Move Property to new_index in section.properties.
@fschrader1992
[test_property.py] Add Test for Section Property Reorder
9324079
@fschrader1992
[property.py] Add Insert Method for Values
3c9cb3f 
Insert property.value at index.
Allows also negative values for index (backwards position).
@fschrader1992
[test_property.py] Add Test for Value Insertion Method
8eddcef
@coveralls
Copy link

coveralls commented Jun 19, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 77.198% when pulling 2316199 on fschrader1992:validation into 66c97fc on G-Node:master.

mpsonntag
mpsonntag approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@mpsonntag mpsonntag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very useful features, nice PR!

@mpsonntag mpsonntag merged commit a231956 into G-Node:master Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpsonntag mpsonntag mpsonntag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fschrader1992 @coveralls @mpsonntag