Always let Dependabot propose Cargo.lock updates
#58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug in the `dependabot.yml` configuration since GitoxideLabs#52, where we intend Dependabot to include the effect of `cargo update`, but this does not happen because `dependency-type: all` was not explicitly allowed. This does not make an analogous change to the Dependabot configuration for GitHub Actions, because `all` and `direct` currently have the same effect for them (and it is not obvious how it would work if that ever changes, or which we would prefer). For details on why this is needed for Dependabot to update most locked dependencies in `Cargo.lock` aside from the case where the update is done as part of updating a `Cargo.toml` dependency, see: - https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/controlling-dependencies-updated#allowing-specific-dependencies-to-be-updated - https://docs.github.com/en/code-security/dependabot/working-with-dependabot/dependabot-options-reference#dependency-type-allow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the
dependabot.ymlconfiguration since #52, where we intend Dependabot to include the effect ofcargo update, but this does not happen becausedependency-type: allwas not explicitly allowed.This does not make an analogous change to the Dependabot configuration for GitHub Actions, because
allanddirectcurrently have the same effect for them (and it is not obvious how it would work if that ever changes, or which we would prefer).For details on why this is needed for Dependabot to update most locked dependencies in
Cargo.lockaside from the case where the update is done as part of updating aCargo.tomldependency, see:The corresponding PR in
gitoxide(where GitoxideLabs/gitoxide#1948 had the same bug as #52) is GitoxideLabs/gitoxide#1967. The description there contains some information applicable both there and here. The fork-internal Dependabot test PR used to validate this was EliahKagan#8.The Dependabot PR that will be created due to this changed configuration will include an attempt to upgrade
pulldown-cmark. Per #54, that will not currently work. Unless work on that is to proceed soon, it may make sense to have Dependabot automatically ignore non-patch updates topulldown-cmark. I might make that change separately, but I haven't attempted to include such a thing here; instead, this PR is only for fixing a specific bug in the configuration I added in #52.