Skip to content

Disable ESC key option #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from
Closed

Disable ESC key option #66

wants to merge 17 commits into from

Conversation

kopeccc
Copy link

@kopeccc kopeccc commented Dec 10, 2019

There may be other components on the vuejs-dialog that use ESC key. It would be great to disable ESC key press event in vuejs-dialog configuration ;-)

Godofbrowser and others added 13 commits March 12, 2019 12:18
* Added prompt

* Update readme with prompt example

* Build scripts

* 1.4.0

* Update translation
Added a comma in options example. Fixed wrong dialog mixin js path where /dist was missing.
Comma in example code and dialog mixin js path in readme
Adding content of prompt even for regular form submit outside clicks
e.g. by clicking enter
add defaultdata to submitDialogForm
Fix loading typo on README
Fixed 'promptHelp' option being in message
@Godofbrowser
Copy link
Owner

Hello @kopeccc Thank you for offering to send in a PR. I'm looking at the changes and it seems like you made a PR from a stale branch Feature/prompt. Have you made any changes to the code yet? If not, then i think it will be best to fork the repository, checkout a new branch before making modifications to the code. After that, you may send a PR from the new branch that was created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants