deps: update to latest @rollup/plugin-typescript #13075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
requested review from
connorjclark
and removed request for
a team
brendankenny
commented
Sep 16, 2021
Comment on lines
+45
to
+50
| // Plugin struggles with custom outDir, so revert it from tsconfig value | ||
| // as well as any options that require an outDir is set. | ||
| outDir: null, | ||
| composite: false, | ||
| emitDeclarationOnly: false, | ||
| declarationMap: false, |
There was a problem hiding this comment.
these override the values in the tsconfig file. Another common pattern is to have a tsconfig.rollup.json file alongside the tsconfig.json with these overrides in there instead. I'm fine with either approach, so whatever you'd prefer @adamraine
There was a problem hiding this comment.
I like having the overrides here. LGTM.
adamraine
approved these changes
Sep 16, 2021
Comment on lines
+45
to
+50
| // Plugin struggles with custom outDir, so revert it from tsconfig value | ||
| // as well as any options that require an outDir is set. | ||
| outDir: null, | ||
| composite: false, | ||
| emitDeclarationOnly: false, | ||
| declarationMap: false, |
There was a problem hiding this comment.
I like having the overrides here. LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously settled on
@rollup/plugin-typescript@^2.1.0even though that's pretty old (Jan 2020) because the latest versions were broken with our typescript setup. The rollup error messages were pretty inscrutable and not worth wading through since the old version was working fine (with the latesttscas a peer dep).#13072 (comment) kind of forces our hand because we want
extendssupport in tsconfig files, so we need a more recent plugin. The fix isn't so bad, it just seems like you really really can't use a customoutDir. The readme gets into this a bit, but that workaround didn't work for me (nor did relocating theoutDirto a few different places). Rather than torturing every path permutation until it worked, it's easier to just disable the customoutDirand any of the properties that force a customoutDirsince we don't need any of those for the plugin's build anyways.Also updates to typescript 4.4.3 because it has a bug fix (microsoft/TypeScript#45642) that fixes the plugin hanging forever with typescript 4.4.* builds.