Skip to content

feat: add flag for ignoring bad connections #2452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kenkania
Copy link

@kenkania kenkania commented May 27, 2025

Port skip-failed-instance-config from v1 to v2. If set, this will ignore connection errors instead of exiting on startup. See more use case details in associated issue.

fixes #2451

@kenkania kenkania requested a review from a team as a code owner May 27, 2025 19:44
@kenkania kenkania changed the title add flag for ignoring bad connections feat: add flag for ignoring bad connections May 27, 2025
@kenkania kenkania requested a review from enocom June 17, 2025 18:52
@kenkania
Copy link
Author

Thanks for the review! I've addressed all your comments, PTAL.

Copy link
Member

@enocom enocom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @hessjcg or @kgala2 are codeowners and have the final say on this, but LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tolerate bad instances when proxying for many instances (unix sockets)
3 participants