fix: remove ConnectorLoopError
from connector.connect
#1170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python packages like gevent have monkey patching abilities and use greenlet
processes to replace synchronous code in an "asynchronous" fashion.
The
ConnectorLoopError
inconnector.connect
was put in as a safe-guard to tryand prevent improper async driver usage where users would accidentally call
connector.connect
forasyncpg
instead of callingconnector.connect_async
,leading to an indefinite hang.
However, this error is preventing support for
gevent
which schedules tasks inits greenlet threads.
Closes #969