Skip to content

fix: upgrade cloudevents to latest if on go1.18 or later #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/buildpack-integration-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ jobs:
cloudevent-builder-source: 'testdata/conformance/function'
cloudevent-builder-target: 'declarativeCloudEvent'
prerun: ${{format('testdata/conformance/prerun.sh {0} testdata/conformance/function', github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha )}}
builder-runtime: 'go113'
builder-runtime-version: '1.13'
builder-runtime: 'go118'
builder-runtime-version: '1.18'
builder-url: gcr.io/gae-runtimes/buildpacks/google-gae-22/go/builder:latest
go116-buildpack-test:
if: github.event.pull_request.head.repo.full_name == github.repository
Expand All @@ -35,8 +35,8 @@ jobs:
cloudevent-builder-source: 'testdata/conformance/function'
cloudevent-builder-target: 'declarativeCloudEvent'
prerun: ${{format('testdata/conformance/prerun.sh {0} testdata/conformance/function', github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha )}}
builder-runtime: 'go116'
builder-runtime-version: '1.16'
builder-runtime: 'go120'
builder-runtime-version: '1.20'
builder-url: gcr.io/gae-runtimes/buildpacks/google-gae-22/go/builder:latest
non-declarative-buildpack-test:
if: github.event.pull_request.head.repo.full_name == github.repository
Expand All @@ -47,6 +47,6 @@ jobs:
cloudevent-builder-source: 'testdata/conformance/nondeclarative'
cloudevent-builder-target: 'CloudEvent'
prerun: ${{format('testdata/conformance/prerun.sh {0} testdata/conformance/nondeclarative', github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha )}}
builder-runtime: 'go116'
builder-runtime-version: '1.16'
builder-url: gcr.io/gae-runtimes/buildpacks/google-gae-22/go/builder:latest
builder-runtime: 'go118'
builder-runtime-version: '1.18'
builder-url: gcr.io/gae-runtimes/buildpacks/google-gae-22/go/builder:latest
4 changes: 2 additions & 2 deletions .github/workflows/conformance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
go-version: [1.13, 1.16, 1.18]
go-version: ['1.18', '1.20']
steps:
- name: Harden Runner
uses: step-security/harden-runner@f086349bfa2bd1361f7909c78558e816508cdc10 # v2.8.0
Expand Down Expand Up @@ -120,4 +120,4 @@ jobs:
-buildpacks=false \
-start-delay=5 \
-cmd="go run testdata/conformance/cmd/declarative/main.go" \
-validate-concurrency=true
-validate-concurrency=true
5 changes: 1 addition & 4 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,8 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
go: ['1.13', '1.16', '1.18']
go: ['1.18', '1.20', '1.20']
os: [ubuntu-latest, macos-latest] # windows-latest doesn't support find -wholename
exclude:
- os: macos-latest
go: 1.13
steps:
- name: Harden Runner
uses: step-security/harden-runner@f086349bfa2bd1361f7909c78558e816508cdc10 # v2.8.0
Expand Down
5 changes: 1 addition & 4 deletions .github/workflows/unit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,8 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
go: ['1.13' ,'1.16', '1.18', '1.19', '1.20', '1.21']
go: ['1.18', '1.19', '1.20', '1.21']
os: [ubuntu-latest, macos-latest, windows-latest]
exclude:
- os: macos-latest
go: 1.13
steps:
- name: Harden Runner
uses: step-security/harden-runner@f086349bfa2bd1361f7909c78558e816508cdc10 # v2.8.0
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Functions Framework for Go

[![GoDoc](https://godoc.org/github.com/GoogleCloudPlatform/functions-framework-go?status.svg)](http://godoc.org/github.com/GoogleCloudPlatform/functions-framework-go) [![Go version](https://img.shields.io/badge/go-v1.11+-blue)](https://golang.org/dl/#stable)
[![GoDoc](https://godoc.org/github.com/GoogleCloudPlatform/functions-framework-go?status.svg)](http://godoc.org/github.com/GoogleCloudPlatform/functions-framework-go) [![Go version](https://img.shields.io/badge/go-v1.18+-blue)](https://golang.org/dl/#stable)

[![Go unit CI][ff_go_unit_img]][ff_go_unit_link] [![Go lint CI][ff_go_lint_img]][ff_go_lint_link] [![Go conformace CI][ff_go_conformance_img]][ff_go_conformance_link] ![Security Scorecard](https://api.securityscorecards.dev/projects/github.com/GoogleCloudPlatform/functions-framework-go/badge)

Expand Down Expand Up @@ -44,7 +44,7 @@ handling logic.

## Quickstart: Hello, World on your local machine

1. Install Go 1.11+.
1. Install Go 1.18+.

1. Create a Go module:
```sh
Expand Down
15 changes: 12 additions & 3 deletions go.mod
Original file line number Diff line number Diff line change
@@ -1,10 +1,19 @@
module github.com/GoogleCloudPlatform/functions-framework-go

go 1.11
go 1.18

require (
cloud.google.com/go/functions v1.16.2
cloud.google.com/go/logging v1.10.0 // indirect
github.com/cloudevents/sdk-go/v2 v2.14.0
github.com/cloudevents/sdk-go/v2 v2.15.2
github.com/google/go-cmp v0.6.0
)

require (
github.com/google/uuid v1.6.0 // indirect
github.com/json-iterator/go v1.1.10 // indirect
github.com/modern-go/concurrent v0.0.0-20180228061459-e0a39a4cb421 // indirect
github.com/modern-go/reflect2 v0.0.0-20180701023420-4b7aa43c6742 // indirect
go.uber.org/atomic v1.4.0 // indirect
go.uber.org/multierr v1.1.0 // indirect
go.uber.org/zap v1.10.0 // indirect
)
Loading
Loading