Revert "Breaking change -- Add support for cloudevent function signat… #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ures (GoogleCloudPlatform#29)" This reverts commit 1989552. The functions framework buildpack has a bug where it pulls from master (instead of from the latest pinned release) for vendored builds, and as this change is breaking, it prevents deployment. Fixes GoogleCloudPlatform#30, https://b.corp.google.com/issues/159732630
tbpg
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ures (#29)"
This reverts commit 1989552.
The functions framework buildpack has a bug where it pulls from master
(instead of from the latest pinned release) for vendored builds, and as
this change is breaking, it prevents deployment. Once the buildpack is
patched, this can be relanded. (problematic call: https://github.com/GoogleCloudPlatform/buildpacks/blob/master/cmd/go/functions_framework/main.go#L169).
Fixes #30, https://b.corp.google.com/issues/159732630