Skip to content

feat: add otlp metric sample with gcp auth #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 22, 2025
Merged

feat: add otlp metric sample with gcp auth #371

merged 2 commits into from
Jan 22, 2025

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Jan 17, 2025 •
edited
Loading

TESTED=manually tested against staging

@dashpole dashpole marked this pull request as ready for review January 17, 2025 20:11
@dashpole dashpole requested a review from a team as a code owner January 17, 2025 20:11
@dashpole dashpole requested a review from aabmass January 21, 2025 19:00
@dashpole
Copy link
Contributor Author

Updated to add the gcp resource detector, which sets required fields (e.g. location).

@dashpole dashpole merged commit 29e3d49 into GoogleCloudPlatform:main Jan 22, 2025
22 checks passed
@dashpole dashpole deleted the otlpmetric branch January 22, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabmass aabmass aabmass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dashpole @aabmass