Skip to content

updates drupal sample for env:flex #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 1, 2016

Conversation

bshaffer
Copy link
Contributor

No description provided.

Copy link
Contributor

@tmatsuo tmatsuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few nits, merge anytime

@@ -1,13 +1,13 @@
Drupal 8 on Managed VMs
=======================
Drupal 8 on App Engine Flexible
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's App Engine Flexible Environment

@@ -4,8 +4,10 @@
},
"require-dev": {
"guzzlehttp/guzzle": "^6.2",
"google/cloud-tools": "<1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we discuss it recently and concluded that we should use "~1.0|~0.5" or something.

@@ -1,4 +0,0 @@
location / {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@bshaffer bshaffer merged commit 1ec200f into upgrade-to-env-flex Nov 1, 2016
@bshaffer bshaffer deleted the upgrade-drupal-to-env-flex branch November 1, 2016 12:08
bshaffer added a commit that referenced this pull request Nov 1, 2016
bshaffer added a commit that referenced this pull request Nov 14, 2016
* Upgrade endpoints to env flex (#230)

* WIP for endpoints on env:flex

* updates tests for endpoints app - requires 'gcloud beta app deploy'

* updates google/cloud-tools version for semantic versioning

* upgrade pubsub sample to env:flex (#228)

* upgrades symfony sample to env:flex (#227)

* upgrades symfony sample to env:flex

* updates google/cloud-tools version for semantic versioning

* upgrade sendgrid sample to env flex (#226)

* upgrades staticcontent sample to env:flex (#225)

* upgradces twilio sample to env:flex (#224)

* update analytics sample for env:flex (#222)

* updates datastore sample to env:flex (#221)

* updates Mailgun sample for env:flex (#220)

* upgrades Mailjet sample for env:flex (#219)

* updates cloudsql sample to env:flex (#218)

* updates drupal sample for env:flex (#217)

* adds proper cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants