Minute workaround #834

jerjou · 2017-02-28T21:09:04Z

A sample for reopening a streaming connection to the speech api, to get around the 1-minute time limit for streaming speech requests.

Addresses #517

theacodes

No tests?

theacodes · 2017-02-28T21:09:54Z

speech/grpc/transcribe_streaming_minute.py

@@ -0,0 +1,294 @@
+#!/usr/bin/python
+# Copyright (C) 2016 Google Inc.


Nit: blank new lines between shebang and license and license and docstring.

theacodes · 2017-02-28T21:10:41Z

speech/grpc/transcribe_streaming_minute.py

+
+    # Create a secure channel using the credentials.
+    http_request = google.auth.transport.requests.Request()
+    target = '{}:{}'.format(host, port)


You don't need to use the port anymore.

theacodes · 2017-02-28T21:11:04Z

speech/grpc/transcribe_streaming_minute.py

+        credentials, http_request, target)
+
+
+def _audio_data_generator(buff, overlap_buffer):


why not just use buffer instead of buff?

I feel like we've had this conversation before :) buffer turns out to be a reserved word.

https://docs.python.org/2/library/functions.html#buffer

oh my god we totally have. Thanks.

theacodes · 2017-02-28T21:11:59Z

speech/grpc/transcribe_streaming_minute.py

+    """A generator that yields all available data in the given buffer.
+
+    Args:
+        buff - a Queue object, where each element is a chunk of data.


Napoleon style is:

Args: buff (Queue): ... overlap_buffer (type): ... Yields: bytes: A chunk of data ...

theacodes · 2017-02-28T21:13:23Z

speech/grpc/transcribe_streaming_minute.py

+
+
+def _fill_buffer(buff, in_data, frame_count, time_info, status_flags):
+    """Continuously collect data from the audio stream, into the buffer."""


nit: unneeded comma here.

theacodes · 2017-02-28T21:15:08Z

speech/grpc/transcribe_streaming_minute.py

+                recognize_stream = service.StreamingRecognize(
+                        requests, DEADLINE_SECS)
+
+        except grpc.RpcError, e:


as e, but if you're not going to use it just do except grpc.RpcError:

theacodes · 2017-02-28T21:15:16Z

speech/grpc/transcribe_streaming_minute.py

+if __name__ == '__main__':
+    parser = argparse.ArgumentParser()
+    parser.add_argument(
+            '-v', '--verbose', help='increase output verbosity',


Indent too deep?

jerjou · 2017-03-01T00:25:43Z

Oh right - tests. Good idea.

Comments addressed - PTAL.

theacodes

I still don't see tests?

theacodes · 2017-03-01T03:24:48Z

speech/grpc/transcribe_streaming_minute.py

@@ -0,0 +1,296 @@
+#!/usr/bin/python
+
+# Copyright (C) 2016 Google Inc.


theacodes · 2017-03-01T03:25:06Z

speech/grpc/transcribe_streaming_minute.py

+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+"""Sample that streams audio to the Google Cloud Speech API via GRPC.


nit nit: I wanted a blank newline between the license and this too. :)

jerjou · 2017-03-01T16:42:26Z

Doh. Forgot to git add -_-
Updated.

jerjou · 2017-03-01T16:42:52Z

Oh wait. travis is unhappy. Bide...

jerjou · 2017-03-01T18:42:24Z

Placated travis. @dpebot would you mind merging if Travis approves?

Jerjou Cheng added 7 commits February 28, 2017 12:53

Working draft of continuous listening.

1c3a63b

Clean up continuous transcription.

ef08207

Indefinite transcoding of utterances

3c543d6

Set WRAP_IT_UP to something more obvious.

4cc06b5

Reduce amount of audio lost between utterances

f7d574f

Add audio overlap.

8e6cec2

Remove utterance sample, so there's only one.

813382f

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 28, 2017

jerjou assigned theacodes and gguuss Feb 28, 2017

theacodes suggested changes Feb 28, 2017

View reviewed changes

Add tests for minute-workaround.

fa9011d

theacodes approved these changes Mar 1, 2017

View reviewed changes

jerjou force-pushed the minute_workaround branch 3 times, most recently from 249e47f to 5900d39 Compare March 1, 2017 05:00

theacodes approved these changes Mar 1, 2017

View reviewed changes

PR feedback.

4d1755c

jerjou force-pushed the minute_workaround branch from 5900d39 to 4d1755c Compare March 1, 2017 18:42

jerjou added the automerge Merge the pull request once unit tests and other checks pass. label Mar 1, 2017

dpebot merged commit 776cef0 into master Mar 2, 2017

dpebot deleted the minute_workaround branch March 2, 2017 00:15

		@@ -0,0 +1,294 @@
		#!/usr/bin/python
		# Copyright (C) 2016 Google Inc.

		credentials, http_request, target)


		def _audio_data_generator(buff, overlap_buffer):



		def _fill_buffer(buff, in_data, frame_count, time_info, status_flags):
		"""Continuously collect data from the audio stream, into the buffer."""

		@@ -0,0 +1,296 @@
		#!/usr/bin/python

		# Copyright (C) 2016 Google Inc.

Minute workaround #834

Minute workaround #834

Uh oh!

Conversation

jerjou commented Feb 28, 2017

Uh oh!

theacodes left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jerjou commented Mar 1, 2017

Uh oh!

theacodes left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jerjou commented Mar 1, 2017

Uh oh!

jerjou commented Mar 1, 2017

Uh oh!

jerjou commented Mar 1, 2017

Uh oh!

Uh oh!