fix carbon intensity geo map #45
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed Behaviour
Currently the "Carbon Intensity across the world" panel is not fully rendering. Screenshot below for reference:
Relevant error message can be seen in the browser console logs:
Local Reproduction
Can see the same behaviour while running the app locally
Issue/Proposed fix
Fix: Initially thought of moving world.geo.json form data folder to assets folder. But felt it's better to add a separate route for world.geo.json. Additionally fixed the loader IO route, which had similar issues with path
Fix: need to map the locations to "properties.ISO_A3" on world.geo.json using "featureidkey"
Behaviour after fix
Would be glad if you can review this PR and let me know of any comments. Happy to address any suggestions and make further commits.
Thanks
Revant