fix[next]: Use CustomMapping for caching of offset provider in program call #2044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edopao
changed the title
tehrengruber
previously approved these changes
May 23, 2025
|
This PR does not solve the problem. I still see all cache misses, probably because some of the values themselves are new objects at each program call. |
edopao
changed the title
edopao
changed the title
edopao
changed the title
edopao
changed the title
|
cscs-ci run default |
egparedes
reviewed
Jun 5, 2025
src/gt4py/next/ffront/decorator.py
Outdated
| try: | ||
| op_extended = self._offset_provider_extended_cache[offset_provider] | ||
| except KeyError: | ||
| op_extended = {**self._implicit_offset_provider, **offset_provider} |
There was a problem hiding this comment.
Suggested change
| op_extended = {**self._implicit_offset_provider, **offset_provider} | |
| op_extended = self._implicit_offset_provider | | |
| offset_provider |
There was a problem hiding this comment.
I get a type error:
error: No overload variant of "__or__" of "dict" matches argument type "Mapping[str, Dimension | NeighborConnectivity]" [operator]
havogt
dismissed
tehrengruber’s stale review
review was for a different implementation
egparedes
approved these changes
Jun 6, 2025
|
cscs-ci run default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the cache key for the offset provider. We use the
eve.utils.CustomMappingclass introduced by #2062 to cache the offset providers in a dictionary and ensure that the key is computed in the same way at compile time and at runtime. This solution is used in two places: the cache for the full offset provider, that contains user-defined and implicit offset providers; and the cache for offset provider type.