Skip to content

fix(locale): unify terminology usage of 'JVM' and 'Java' #3690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

3gf8jv4dv
Copy link
Contributor

@3gf8jv4dv 3gf8jv4dv commented Mar 2, 2025

  • For Chinese, replace the relevant term with 'Java 虚拟机/虛擬機'.
  • For other languages, replace the relevant term with 'JVM'.
  • Replace 'JVM' with 'Java' in some cases where 'JVM' is inappropriate.

@3gf8jv4dv 3gf8jv4dv force-pushed the jvm-term branch 2 times, most recently from 5746153 to fd1e8bc Compare March 7, 2025 11:33
@3gf8jv4dv 3gf8jv4dv force-pushed the jvm-term branch 2 times, most recently from a17ee60 to 6c67241 Compare May 10, 2025 05:38
@3gf8jv4dv 3gf8jv4dv force-pushed the jvm-term branch 2 times, most recently from f0061a1 to 11c1af7 Compare June 8, 2025 13:37
@Glavo Glavo requested a review from Copilot June 11, 2025 13:58
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR unifies the terminology for referring to Java and its virtual machine across locale resource files. The changes update several error and informational messages to replace inconsistent references to “Java 虚拟机”/“Java VM” with either “Java” or “JVM” as appropriate.

  • Updated error messages and instructions in multiple locale files to reflect the unified terminology.
  • Adjusted settings labels in the advanced options to change “Java 虚拟机” or “Java VM” to “JVM” consistently.
  • Ensured that both localized and English versions adhere to the revised naming conventions.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties Replaced “Java 虚拟机” with “Java” or “JVM” in error messages and settings.
HMCL/src/main/resources/assets/lang/I18N_zh.properties Updated locale strings to unify terminology usage for Java and its VM.
HMCL/src/main/resources/assets/lang/I18N_ru.properties Changed references from “Java VM” to “JVM” in settings and error messages.
HMCL/src/main/resources/assets/lang/I18N_es.properties Unified terminology by replacing “máquina virtual de Java” with “Java” or “JVM” where applicable.
HMCL/src/main/resources/assets/lang/I18N.properties Revised the English error messages and settings to maintain consistency in using “Java” versus “JVM”.
Comments suppressed due to low confidence (5)

HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties:371

  • Ensure that the replacement of “Java 虚拟机” with “Java” here is consistent with its intended meaning, and that it is clear to users that it refers to the runtime environment.
exception.ssl_handshake=无法建立 SSL 连接。当前 Java 缺少相关的 SSL 证书。你可以尝试使用其他 Java 启动 HMCL 再试。

HMCL/src/main/resources/assets/lang/I18N_zh.properties:431

  • Verify that the updated message clearly communicates that it is the Java runtime version (and not the virtual machine itself) that needs to be compatible with the game.
game.crash.reason.need_jdk11=目前遊戲由於 Java 版本不合適,無法繼續執行。\n你需要下載安裝 Java 11,並在「(全域/實例特定) 遊戲設定 → 遊戲 Java」中將 Java 設定為 11.x 的版本。

HMCL/src/main/resources/assets/lang/I18N_ru.properties:1215

  • Confirm that changing the label from ‘Java VM’ to ‘JVM’ is aligned with the overall language style guide and is understandable for all users.
settings.advanced.dont_check_jvm_validity=Не проверять совместимость JVM

HMCL/src/main/resources/assets/lang/I18N_es.properties:772

  • [nitpick] Review the phrasing to ensure that the removal of the term referring to the virtual machine (“máquina virtual de Java”) in the first sentence remains clear and consistent with later usage of “JVM”.
launch.advice.corrected=Hemos solucionado el problema de la Java. Si todavía quieres utilizar la versión de Java que elijas, puedes desactivar la opción «No comprobar la compatibilidad de la JVM» en «Config. Global/Específica de instancia → Configuración avanzada».

HMCL/src/main/resources/assets/lang/I18N.properties:657

  • Ensure that the change from ‘Java VM’ to ‘Java’ clearly indicates that it is the overall Java version that is outdated and that users are directed to update their runtime accordingly.
game.crash.reason.too_old_java=The game crashed because you are using an outdated Java version.

@Glavo
Copy link
Member

Glavo commented Jun 11, 2025

我比较担心“JVM”这个术语会不会给用户带来困扰。

我感觉对于小白用户来说,“Java 虚拟机”中包含“Java”这个词,一眼就能看出来这个词和 Java 的关系,但 JVM 就不行,所以可能会让很多用户对此感到困惑。

@3gf8jv4dv
Copy link
Contributor Author

我比较担心“JVM”这个术语会不会给用户带来困扰。

我感觉对于小白用户来说,“Java 虚拟机”中包含“Java”这个词,一眼就能看出来这个词和 Java 的关系,但 JVM 就不行,所以可能会让很多用户对此感到困惑。

如果只为简繁用户保留 “Java 虚拟机”,其他语言保留 “JVM”,如何?

@Glavo
Copy link
Member

Glavo commented Jun 28, 2025

如果只为简繁用户保留 “Java 虚拟机”,其他语言保留 “JVM”,如何?

我觉得可以

@3gf8jv4dv 3gf8jv4dv force-pushed the jvm-term branch 2 times, most recently from 216f3ee to 7d5ec97 Compare June 29, 2025 15:04
- For Chinese, replace the relevant term with 'Java 虚拟机/虛擬機'.
- For other languages, replace the relevant term with 'JVM'.
- Replace 'JVM' with 'Java' in some cases where 'JVM' is inappropriate.
@3gf8jv4dv
Copy link
Contributor Author

Now complete. CC @Glavo

@3gf8jv4dv 3gf8jv4dv changed the title fix(locale): unify terminology usage of JVM and Java fix(locale): unify terminology usage of 'JVM' and 'Java' Jun 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants