微软账号皮肤相关修改 #3858

CiiLu · 2025-04-25T23:22:33Z

内容：

微软账户皮肤增加3D预览
支持修改披风
皮肤上传增加模型选择

Wulian233 · 2025-04-26T08:32:08Z

需要至少实现简中和英语的翻译

> Task :checkTranslations FAILED
I18N.properties missing key 'account.skin.upload'
FAILURE: Build failed with an exception.
I18N.properties missing key 'account.skin.select_model'

I18N.properties missing key 'account.cape.none'
* What went wrong:
I18N.properties missing key 'account.cape.change'
Execution failed for task ':checkTranslations'.
I18N_zh.properties missing key 'account.cape.none'
> Part of the translation is missing
I18N_zh.properties missing key 'account.cape.change'

3gf8jv4dv · 2025-04-26T09:07:29Z

需要至少实现简中和英语的翻译

I18N_zh.properties 是繁体中文。此外构建时要求简繁英都要有对应翻译。

3gf8jv4dv · 2025-04-26T09:09:33Z

考虑为披风名添加翻译吗？

HMCL/src/main/resources/assets/lang/I18N_zh.properties

HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties

HMCL/src/main/resources/assets/lang/I18N.properties

Co-authored-by: 3gf8jv4dv <[email protected]>

CiiLu · 2025-04-26T10:05:34Z

考虑为披风名添加翻译吗？

如果这个 PR 被合并，后续会在独立 PR 中添加翻译

burningtnt · 2025-04-28T13:43:55Z

若要加入披风选择功能，应直接在启动器内加入数个披风的贴图以允许玩家可视化地选择披风

CiiLu · 2025-05-01T01:54:27Z

翻译（来自 Minecraft Wiki）+预览（选中）

Wulian233 · 2025-05-01T02:07:26Z

HMCL/src/main/java/org/jackhuang/hmcl/ui/account/MicrosoftAccountSkinPane.java

@@ -0,0 +1,203 @@
+/*
+ * Hello Minecraft! Launcher
+ * Copyright (C) 2021  huangyuhui <[email protected]> and contributors


Suggested change

* Copyright (C) 2021 huangyuhui <huanghongxun2008@126.com> and contributors

* Copyright (C) 2025 huangyuhui <huanghongxun2008@126.com> and contributors

无关紧要的小建议~

不应更新版权信息年份

zkitefly · 2025-05-01T03:20:34Z

感觉这个页面非常空，或许可以将披风选择的选择页面搬到前面而不需要跳转至二级页面

HMCL/src/main/resources/assets/lang/I18N_zh.properties

HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties

HMCL/src/main/resources/assets/lang/I18N.properties

HMCL/src/main/resources/assets/lang/I18N_es.properties

HMCL/src/main/resources/assets/lang/I18N_ru.properties

Co-authored-by: 3gf8jv4dv <[email protected]>

zkitefly · 2025-05-09T12:36:19Z

来自群友反馈，披风太多会顶窗口

Wulian233 · 2025-05-09T12:44:12Z

之前的2019十周年金色苦力怕披风和Pan都是基岩版独占的，最近同步java了。还有普通披风，登录基岩版获得，还需要同步一下翻译

3gf8jv4dv

可供选择的披风选项现在看起来像是居中，且会受到右侧披风图像加载与否的影响（转圈时/呈现图像时文本会跳动）。

HMCL/src/main/resources/assets/lang/I18N.properties

Co-authored-by: 3gf8jv4dv <[email protected]>

burningtnt

标题“皮肤”略有不妥，可改为“皮肤与披风”；右侧的空白有些奇怪

应当在此界面提供取消、重选文件和皮肤预览功能（即在左侧渲染对应皮肤）

异常的对齐。此外，右侧的图片在加载过程中高度为 0，因此会出现对话框高度抖动，请通过设置图片的 prefHeight 来解决

burningtnt · 2025-06-07T11:03:38Z

HMCL/src/main/java/org/jackhuang/hmcl/ui/account/AccountListItem.java

    public Task<?> uploadSkin() {
        if (account instanceof OfflineAccount) {
-            Controllers.dialog(new OfflineAccountSkinPane((OfflineAccount) account));
-            return null;
+            return Task.runAsync(Schedulers.javafx(), () -> {


质疑此处分别对 OfflineAccount 和 MicrosoftAccount 处理，会增加耦合性。如果可能，请使用面向对象的思维处理不同账户类型的操作。

burningtnt · 2025-06-07T11:06:03Z

HMCL/src/main/java/org/jackhuang/hmcl/ui/account/MicrosoftAccountChangeCapeDialog.java

+            } catch (ResourceNotFoundError error) {
+                previewCapeImage = FXUtils.newRemoteImage(capeItem.getSelectedData().getUrl());
+            }
+            previewCapeImage = scaleImageNearestNeighbor(previewCapeImage, 10, 10);


你在重复造轮子 :( 请使用 JavaFX 的 ImageView 来转换图片大小

HMCL/src/main/java/org/jackhuang/hmcl/ui/account/MicrosoftAccountChangeCapeDialog.java

burningtnt · 2025-06-07T11:07:35Z

HMCL/src/main/java/org/jackhuang/hmcl/ui/account/MicrosoftAccountSkinPane.java

@@ -0,0 +1,203 @@
+/*
+ * Hello Minecraft! Launcher
+ * Copyright (C) 2021  huangyuhui <[email protected]> and contributors


不应更新版权信息年份

burningtnt · 2025-06-07T11:13:08Z

HMCLCore/src/main/java/org/jackhuang/hmcl/auth/microsoft/MicrosoftService.java

    }

    public static class MinecraftProfileResponseCape {
+        String id;


用于 Gson 序列化的字段应当标记为 private final

burningtnt · 2025-06-07T11:13:42Z

HMCLCore/src/main/java/org/jackhuang/hmcl/auth/microsoft/MicrosoftService.java

+        String id;
+        String state;
+        String url;
+        String variant; // CLASSIC, SLIM


既然这是一个 Enum，则应当使用对应的 Enum 作为类型。同样，请标记为 private final

HMCLCore/src/main/java/org/jackhuang/hmcl/auth/microsoft/MicrosoftService.java

CiiLu added 9 commits April 26, 2025 06:46

update

bc08223

update

e941aa9

update

df5705e

update

67d76ba

update

a013a4b

update

b9d28a8

撞了

548488f

撞了

2843e10

update

853f4e8

burningtnt mentioned this pull request Apr 26, 2025

PR Collection 开发进展 burningtnt/HMCL#9

Open

CiiLu added 7 commits April 26, 2025 13:09

update

8816941

update

e06a42c

update

046aab5

update

cc6eb8a

update

5e6c683

update

ed49a29

Update MicrosoftService.java

dfd3f86

3gf8jv4dv suggested changes Apr 26, 2025

View reviewed changes

Apply suggestions from code review

40d40b3

Co-authored-by: 3gf8jv4dv <[email protected]>

CiiLu added 6 commits April 30, 2025 23:20

update

f85410e

Merge remote-tracking branch 'origin/skin' into skin

477b503

update

6478eae

update

98ae6cc

update

d7a8421

update

42bd42a

CiiLu added 4 commits May 1, 2025 00:04

update

7ba1ddb

预览&i18n

9368d7f

繁体中文

b31cffc

十五周年披风&首次进入

a3db0c3

CiiLu marked this pull request as ready for review May 1, 2025 01:54

Wulian233 reviewed May 1, 2025

View reviewed changes

3gf8jv4dv suggested changes May 1, 2025

View reviewed changes

Apply suggestions from code review

38e8cf9

Co-authored-by: 3gf8jv4dv <[email protected]>

CiiLu added 2 commits May 10, 2025 20:22

新披风译名

c503bf7

滚动条

5238468

3gf8jv4dv reviewed May 10, 2025

View reviewed changes

HMCL/src/main/resources/assets/lang/I18N.properties Outdated Show resolved Hide resolved

HMCL/src/main/resources/assets/lang/I18N.properties Outdated Show resolved Hide resolved

Apply suggestions from code review

84ce65e

Co-authored-by: 3gf8jv4dv <[email protected]>

zkitefly mentioned this pull request Jun 7, 2025

新增"修改披风"功能 #3977

Closed

burningtnt suggested changes Jun 7, 2025

View reviewed changes

CiiLu added 10 commits June 7, 2025 19:56

Update

09165eb

Update

81f84a7

CheckStyle

7b74456

CheckStyle

82159bb

标题

7bb9166

解决披风弹窗抖动

67d4248

添加取消按钮

237ce46

CheckStyle

ba40768

修改布局

2b92efe

checkStyle

9a83e60

	* Copyright (C) 2021 huangyuhui <huanghongxun2008@126.com> and contributors
	* Copyright (C) 2025 huangyuhui <huanghongxun2008@126.com> and contributors

微软账号皮肤相关修改 #3858

Are you sure you want to change the base?

微软账号皮肤相关修改 #3858

Uh oh!

Conversation

CiiLu commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Wulian233 commented Apr 26, 2025

Uh oh!

3gf8jv4dv commented Apr 26, 2025

Uh oh!

3gf8jv4dv commented Apr 26, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CiiLu commented Apr 26, 2025

Uh oh!

burningtnt commented Apr 28, 2025

Uh oh!

CiiLu commented May 1, 2025

Uh oh!

Wulian233 May 1, 2025

Choose a reason for hiding this comment

Uh oh!

burningtnt Jun 7, 2025

Choose a reason for hiding this comment

Uh oh!

zkitefly commented May 1, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zkitefly commented May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Wulian233 commented May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

3gf8jv4dv left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

burningtnt left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

burningtnt Jun 7, 2025

Choose a reason for hiding this comment

Uh oh!

burningtnt Jun 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

burningtnt Jun 7, 2025

Choose a reason for hiding this comment

Uh oh!

burningtnt Jun 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

burningtnt Jun 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

CiiLu commented Apr 25, 2025 •

edited

Loading

zkitefly commented May 9, 2025 •

edited

Loading

Wulian233 commented May 9, 2025 •

edited

Loading

burningtnt left a comment •

edited

Loading

burningtnt Jun 7, 2025 •

edited

Loading

burningtnt Jun 7, 2025 •

edited

Loading