chore(locale): add tip translation of deprecated java ver for ru and es #4043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and fix a previous typo.
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new translation tip for deprecated Java versions and fixes an existing typo in the Russian and Spanish language resource files.
- Added a new translation key (fatal.deprecated_java_version.update) for both RU and ES files.
- Adjusted text to direct users towards using newer Java versions while still allowing legacy versions.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| HMCL/src/main/resources/assets/lang/I18N_ru.properties | Added fatal.deprecated_java_version.update and updated translation block formatting |
| HMCL/src/main/resources/assets/lang/I18N_es.properties | Added fatal.deprecated_java_version.update and updated translation block formatting |
Comments suppressed due to low confidence (4)
HMCL/src/main/resources/assets/lang/I18N_ru.properties:406
- [nitpick] Consider using the imperative form (e.g., 'Пожалуйста, установите') for user instructions to ensure consistency in tone.
fatal.deprecated_java_version.update=В будущем для работы HMCL потребуется Java 11 или более поздняя версия. Пожалуйста, установить последнюю версию Java, чтобы убедиться, что приложение сможет завершить обновление.\n\
HMCL/src/main/resources/assets/lang/I18N_ru.properties:407
- [nitpick] Verify that the whitespace and newline formatting in the added translation block aligns with the existing style for clarity.
\n\
HMCL/src/main/resources/assets/lang/I18N_es.properties:408
- [nitpick] Consider revising the text to use the imperative form (e.g., 'Por favor, instale') for a more instructive and consistent tone.
fatal.deprecated_java_version.update=HMCL requerirá Java 11 o posterior para funcionar en el futuro. Por favor, instalar la última versión de Java para asegurarse de que el lanzador puede completar la actualización.\n\
HMCL/src/main/resources/assets/lang/I18N_es.properties:409
- [nitpick] Ensure the added whitespace and newline formatting is consistent with existing translations to maintain clarity.
\n\
Glavo
approved these changes
Jun 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and fix a previous typo.