Skip to content

Turn project into a custom Unity package #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cyrilBoucher
Copy link

- Add the necessary package.json file to describe what this package will
contain
- Move files into a Runtime folder to follow package layout found here:
https://docs.unity3d.com/Manual/cus-layout.html
@cyrilBoucher
Copy link
Author

cyrilBoucher commented Jul 21, 2020

@HiddenMonk Hi! I created a pull request to make your project usable through the package manager. The PR says it will be merged into master but I am not sure if that should be the case, other repositories like https://github.com/ValveSoftware/steamvr_unity_plugin have a specific branch for the package and other branches are just the normal Unity project layout (Asset folder, etc...).

That's why I made it a draft so that it does not get merged by mistake.

Maybe the right way to do this would be for you to have a specific branch and I could merge into that one? What do you think?

EDIT: Actually they recently removed said branch...

@HiddenMonk
Copy link
Owner

Hey =), thats really cool, I didnt know you can make custom packages for unity to grab from github.
However, I dont want to worry about managing it since I dont know much about this stuff and might not be working on this gizmo anymore, but I put your fork in the ReadMe so people can see your version for the package manager, if thats all right with you.

@cyrilBoucher
Copy link
Author

cyrilBoucher commented Jul 21, 2020

Yup, I totally understand! On top of that, Unity doesn't seem to make it easy to manage... I am good with a simple link in the ReadMe for anyone interested in using it that way! I will proceed and close the PR!

@HiddenMonk
Copy link
Owner

=) sounds good. Up to you to close the pr, I dont mind it open for people to have another way to find it.

@cyrilBoucher
Copy link
Author

True! I will leave it open as a Draft then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants