Skip to content

feat: support for windows + add ci task #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 1, 2021
Merged

Conversation

Himenon
Copy link
Owner

@Himenon Himenon commented Apr 1, 2021

Summary

Test Plan

  • add windows os

@Himenon Himenon changed the title feat: support windows feat: support for windows Apr 1, 2021
@Himenon Himenon merged commit 77a4d8f into main Apr 1, 2021
@Himenon Himenon deleted the feat/support-windows branch April 1, 2021 15:14
@Himenon Himenon changed the title feat: support for windows feat: support for windows + add ci task Apr 1, 2021

strategy:
matrix:
node-version: [12.x]
os: [windows-latest, ubuntu-latest]
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add

expect(generate("/a/{b}/c", [{ in: "path", name: "b", required: true }])).toBe("`/a/${params.parameter.b}/c`;" + EOL);
expect(generate("/a/{b}/c/", [{ in: "path", name: "b", required: true }])).toBe("`/a/${params.parameter.b}/c/`;" + EOL);
expect(generate("/a/b/{c}", [{ in: "path", name: "c", required: true }])).toBe("`/a/b/${params.parameter.c}`;" + EOL);
expect(generate("/a/b/{c}/", [{ in: "path", name: "c", required: true }])).toBe("`/a/b/${params.parameter.c}/`;" + EOL);
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update

@@ -14,7 +14,7 @@ export const escapeIdentiferText = (text: string): string => {
};

export const generateComment = (comment: string, deprecated?: boolean): Comment => {
const splitComments = deprecated ? ["@deprecated"].concat(comment.split(EOL)) : comment.split(EOL);
const splitComments = deprecated ? ["@deprecated"].concat(comment.split(/\r?\n/)) : comment.split(/\r?\n/);
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants