Skip to content

go 1.25rc1, [email protected] 1.24.4 (new formula) #226636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

stefanb
Copy link
Member

@stefanb stefanb commented Jun 12, 2025

Announcement:

Release notes:

Go 1.24 milestone: GitHub milestone details (release blockers, commits, PRs)

Go release dashboard: https://dev.golang.org/release

Downloads: https://go.dev/dl/

Related/similar previous:

Builds:

Problematic dependants formulae:

Due to Go 1.25 changes

Needs specific support for Go 1.25 upstream

  • garble: test failure: Go linker patches aren't available for go1.25 or later yet

Formula revision bump needed

  • golangci-lint: test failure: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25)
  • govulncheck: test failure: Loading packages failed, possibly due to a mismatch between the Go version used to build govulncheck and the Go version on PATH. Consider rebuilding govulncheck with the current Go version.
  • staticcheck: test failure: module requires at least go1.25rc1, but Staticcheck was built with go1.24.4

Needs golang.org/x/tools bump to >= v0.34.0

Hash mismatches

  • buildpulse-test-reporter hash mismatch: Expected: 4235de52b6068f9f3d2d04f3b43ca8d2de1d1e421ae3cfbcdbcef2629d9b8263 Actual: 605e87f4d566f14455f6c1e609eabd3fc2337a09d695fafc489011ce48b02035
  • gnmic: hash mismatch: Expected: 79db2cdd7dfe55edefdb7dcdd1c4403fdc5cb9378385f23456d16a740cc6ec24 Actual: a684f627680eff51acec81f8eb3c4fa920c32b05afde0c040e9c51d1d2fe3067
  • go-blueprint: hash mismatch: Expected: 6377012d2899867b5a32f67b810d19cb44b6eb14a3caa8214cb969f69209a51b Actual: 4d8a04a3eabdeddce0ec1f77dddaa23dfe480150d9222e7dcebaccaff86b9c1f
  • humanlog: hash mismatch: `Expected: f57cc04582a84cc786ea1a9198ea2866fd269c2ab5a2df4ea6f9998394786186 Actual: 70fe4f955d19c92cef6249f5aa1fbb54a1c60fabf4674a4bfd2c0ce333efed57
  • ksops: hash mismatch: Expected: d498284ee6a523fd4b87d284693b313fea289b4a374f2c0d1b5023f2b18bf77a Actual: 08891e25bfac225ac90fd6ccc20ec5d8d0dff96222d86eaafeb976d85bb338f0
  • kubevpn: hash mismatch: Expected: 24c7728797fb614c0fd69fcd878b872835d889cf25e8a140898a107f282ff999 Actual: 05ab7c1dc46e0904013d6c70583c48597a5a9447aeaacfb059b3c187c8b8c633
    kubevpn 2.7.19 #227250
  • kumactl: hash mismatch: Expected: 1887e12a27b779d41111347bc5181573165cf6063bbcd622b50977d26c4e2a59 Actual: 27048e7dbad0841f146fdb3ddb9031ae959463fe76b3fb8944a19ed5253e6c56
  • mdz: hash mismatch: Expected: f74b30f2d62e0ab002c104b075ffda8a9574a8597a73abc31bfa7b7e264d3517 Actual: 62c623ac6ff9507eff68d1a66d335fc8878065ff563639e493b3cc216145234a
    mdz 2.2.2 #227043
  • mongodb-atlas-cli: hash mismatch: Expected: 89be7e6cecd3620b73d257b710b9b2dbe04ce16bfd28adf4c656ed94968520ac Actual: ac50cb1fc211f1227e0a3e2da19375e9f6d60a5f06cea524169489213a4b6fae
    mongodb-atlas-cli 1.44.0 #227619
  • ocm: hash mismatch: Expected: 2773eb36c66cea85f4fb6aa5f0ffbf323046dae2b1ed5a37f18b487022f6414b Actual: 4f9ad5c5a315053489b45e9a734999b2524140af45429853428b07b49b0aa5e2
  • percona-toolkit: hash mismatch: Expected: e79f53c3227ac31c858fad061d8a000162cb5ecf8b446b90b574adde9e9ab455 Actual: ac8a20b8cf0c5c214eac43e9456fcf75c7482c3fba0f821382098bd5ea011a13
    percona-toolkit 3.7.0-2 #226606
  • rosa-cli: hash mismatch: Expected: 4352b72f94d22d3a29aa20b4793c19472ca3c1ba1c689676bb37f8c7a453ecf6 Actual: 6ce9b21640eec97c4003b378434dd0d78afc22ac5f4336233b3f003c6c4967c6

Transient

  • eget: test failure: Github API rate limit exceeded
  • openbao: build failure: YN0000: Failed with errors in 26m 5s
  • parca: build failure: ERR_PNPM_FETCH_504  GET https://registry.npmjs.org/@storybook%2Faddon-docs: Gateway Timeout - 504
  • phoneinfoga: build failure: The remote server failed to provide the requested resource ➤ YN0035: │ Response Code: 503 (Service Unavailable)
  • prometheus: build failure: fatal: not a git repository (or any of the parent directories): .git, npm error 503 Service Unavailable
  • sqlboiler: build failure: go: downloading modernc.org/sqlite v1.18.1 drivers/sqlboiler-sqlite3/driver/sqlite3.go:12:2: modernc.org/[email protected]: Get "https://proxy.golang.org/modernc.org/sqlite/@v/v1.18.1.zip": dial tcp 74.125.193.141:443: connect: operation timed out

Other / Unknown / not yet categorized


  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@stefanb stefanb added in progress Stale bot should stay away prerelease-testing Pull request from upstream, testing a pre-release with homebrew dependencies CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. long dependent tests Set a long timeout for dependent testing labels Jun 12, 2025
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request new formula PR adds a new formula to Homebrew/homebrew-core CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. autobump alias labels Jun 12, 2025
@stefanb stefanb marked this pull request as draft June 12, 2025 04:29
@chenrui333
Copy link
Member

looks like linux arm dependency builds did not get triggered.

kezhenxu94 pushed a commit to apache/skywalking-eyes that referenced this pull request Jun 14, 2025
The build error with Go 1.25 manifests as:
go1.25rc1 build ./...
# golang.org/x/tools/internal/tokeninternal
../../../go/pkg/mod/golang.org/x/[email protected]/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64)

updated via
go get -u golang.org/x/tools
go mod tidy

Related:
* Go proposal: golang/go#73205
* Upstream x/tools fix: https://go-review.googlesource.com/c/tools/+/675955
* Problem found in Homebrew/homebrew-core#226636
mhilton pushed a commit to influxdata/flux that referenced this pull request Jun 16, 2025
…lity (#5543)

Build with Go 1.25 fails with:
  go generate -tags '' ./libflux/go/libflux
  env GO111MODULE=on go build -tags '' ./...
  go: downloading github.com/dave/jennifer v1.2.0
  go: downloading golang.org/x/mod v0.18.0
  # golang.org/x/tools/internal/tokeninternal
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/golang.org/x/[email protected]/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64)
  make: *** [build] Error 1

Bumped via:
go1.25rc1 get -u golang.org/x/tools
go: upgraded golang.org/x/crypto v0.36.0 => v0.39.0
go: upgraded golang.org/x/mod v0.24.0 => v0.25.0
go: upgraded golang.org/x/net v0.38.0 => v0.41.0
go: upgraded golang.org/x/sync v0.12.0 => v0.15.0
go: upgraded golang.org/x/sys v0.31.0 => v0.33.0
go: upgraded golang.org/x/term v0.30.0 => v0.32.0
go: upgraded golang.org/x/text v0.23.0 => v0.26.0
go: upgraded golang.org/x/tools v0.30.0 => v0.34.0

go1.25rc1 mod tidy

Related:
* Go proposal: golang/go#73205
* Upstream `golang.org/x/tools` fix: https://go-review.googlesource.com/c/tools/+/675955 / golang/tools@2815c8b
* Problem found in Homebrew/homebrew-core#226636
stefanb added a commit to stefanb/legitify that referenced this pull request Jun 19, 2025
The build error with Go 1.25 manifests as:

go1.25rc1 build ./...
# golang.org/x/tools/internal/tokeninternal
../../../go/pkg/mod/golang.org/x/[email protected]/internal/tokeninternal/tokeninternal.go:78:9: invalid array length -delta * delta (constant -256 of type int64)

go1.25rc1 get -u golang.org/x/tools
go: upgraded go 1.19 => 1.23.0
go: upgraded golang.org/x/crypto v0.21.0 => v0.39.0
go: upgraded golang.org/x/mod v0.12.0 => v0.25.0
go: upgraded golang.org/x/net v0.23.0 => v0.41.0
go: upgraded golang.org/x/sync v0.3.0 => v0.15.0
go: upgraded golang.org/x/sys v0.20.0 => v0.33.0
go: upgraded golang.org/x/term v0.18.0 => v0.32.0
go: upgraded golang.org/x/text v0.14.0 => v0.26.0
go: upgraded golang.org/x/tools v0.13.0 => v0.34.0

go1.25rc1 mod tidy

Related:
* Go proposal: golang/go#73205
* Upstream `golang.org/x/tools` fix: https://go-review.googlesource.com/c/tools/+/675955 / golang/tools@2815c8b
* Problem found in Homebrew/homebrew-core#226636
hailaz added a commit to gogf/gf that referenced this pull request Jun 20, 2025
…4313)

chore: bump golang.org/x/tools to v0.34.0 for Go 1.25 compatibility

```
   # golang.org/x/tools/internal/tokeninternal
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/golang.org/x/[email protected]/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64)
```

relates to Homebrew/homebrew-core#226636
stefanb added a commit to stefanb/pebble that referenced this pull request Jun 25, 2025
RaduBerinde pushed a commit to cockroachdb/pebble that referenced this pull request Jun 25, 2025
stefanb added a commit to stefanb/kubo that referenced this pull request Jun 25, 2025
Go 1.25 incompatibility detected in
* Homebrew/homebrew-core#226636

then:
* reported upstream in cockroachdb/swiss#48
* fixed upstream cockroachdb/swiss#49

This PR brings this fix upstream to kubo.

Alternatively we could wait until
* cockroachdb/pebble#4954
is included in a release and then update direct dependancy module github.com/cockroachdb/pebble/v2
stefanb added a commit to stefanb/kubo that referenced this pull request Jun 25, 2025
Go 1.25 incompatibility detected in
* Homebrew/homebrew-core#226636

then:
* reported upstream in cockroachdb/swiss#48
* fixed upstream cockroachdb/swiss#49

This PR brings this fix upstream to kubo.

Alternatively we could wait until
* cockroachdb/pebble#4954
is included in a release and then update direct dependancy module github.com/cockroachdb/pebble/v2
stefanb added a commit to stefanb/kubo that referenced this pull request Jun 26, 2025
Go 1.25 incompatibility detected in
* Homebrew/homebrew-core#226636

then:
* reported upstream in cockroachdb/swiss#48
* fixed upstream cockroachdb/swiss#49

This PR brings this fix upstream to kubo.

The fix was brought to github.com/cockroachdb/pebble/v2 in
* cockroachdb/pebble#4954

And released in https://github.com/cockroachdb/pebble/releases/tag/v2.0.6
Which is now used.

Full changelog: cockroachdb/pebble@v2.0.3...v2.0.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alias autobump automerge-skip `brew pr-automerge` will skip this pull request CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. in progress Stale bot should stay away long dependent tests Set a long timeout for dependent testing new formula PR adds a new formula to Homebrew/homebrew-core prerelease-testing Pull request from upstream, testing a pre-release with homebrew dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants