fix(build): Add CRK ID Filter to List KMIP Adapters (#127)

MDarmawan · william8siew · stephaniegalang-ibm · web-flow · commit fb6c853f04f0 · 2024-06-03T10:36:00.000-05:00
* rename keyring path for conflicts Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> * initial implementation of adapters and certs Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> * add kmip objects, fix some stuff Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> * fix structs Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> * unit tests, and some fixes Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> * remove import cycle Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> * redo mocks Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> * add mockauth Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> * fix mobk paths Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> * fix marshalling Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> * fix delete tests Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> * remove old kmip profile data Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> * address PR comments Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> * finish address comments Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> * hardcode mock responses, refactor kmip collection metadata Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> * fix tests? Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> * fix typo Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> * add object filter, overhaul list options Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> * enhance tests Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> * unexport path variables, add comments Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> * sdk fixes Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> * remove crk from adapter list Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> * add crkID filter Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> * feat(build): Update travis distribution in CI file (#123) * change travis dist Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> * add npm install check to travis Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> * real fix Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> * change python version Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> * remove pyenv, let it use default python version of 3.10 Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> --------- Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> * add info to contributing about the semantic release (#124) Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> * instpol attrib enabled only (#125) Signed-off-by: stephaniegalang <stephaniegalang@ibm.com> Co-authored-by: stephaniegalang <stephaniegalang@ibm.com> Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> * Allow instance policy attributes to be optionally specified (#126) * allow attributes to be specified optionally Signed-off-by: stephaniegalang <stephaniegalang@ibm.com> * propogate attributes, ignoring disable Signed-off-by: stephaniegalang <stephaniegalang@ibm.com> --------- Signed-off-by: stephaniegalang <stephaniegalang@ibm.com> Co-authored-by: stephaniegalang <stephaniegalang@ibm.com> Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> * fix missed merge artifacts Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> --------- Signed-off-by: Michael Darmawan <michael.darmawan@ibm.com> Signed-off-by: stephaniegalang <stephaniegalang@ibm.com> Co-authored-by: William Siew <38149204+william8siew@users.noreply.github.com> Co-authored-by: stephaniegalang <stephaniegalang@ibm.com>
diff --git a/kmip_mgmt_adapters.go b/kmip_mgmt_adapters.go
@@ -82,6 +82,7 @@ type ListKmipAdaptersOptions struct {
 	Limit      *uint32
 	Offset     *uint32
 	TotalCount *bool
+	CrkID      *string
 }
 
 // GetKMIPAdapters method lists KMIP Adapters associated with a specific KP instance.
@@ -103,6 +104,9 @@ func (c *Client) GetKMIPAdapters(ctx context.Context, listOpts *ListKmipAdapters
 		if listOpts.TotalCount != nil {
 			values.Set("totalCount", fmt.Sprint(*listOpts.TotalCount))
 		}
+		if listOpts.CrkID != nil {
+			values.Set("crk_id", *listOpts.CrkID)
+		}
 		req.URL.RawQuery = values.Encode()
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -82,6 +82,7 @@ type ListKmipAdaptersOptions struct {`
`82`	`82`	`Limit *uint32`
`83`	`83`	`Offset *uint32`
`84`	`84`	`TotalCount *bool`
	`85`	`+ CrkID *string`
`85`	`86`	`}`
`86`	`87`
`87`	`88`	`// GetKMIPAdapters method lists KMIP Adapters associated with a specific KP instance.`
`@@ -103,6 +104,9 @@ func (c Client) GetKMIPAdapters(ctx context.Context, listOpts ListKmipAdapters`
`103`	`104`	`if listOpts.TotalCount != nil {`
`104`	`105`	`values.Set("totalCount", fmt.Sprint(*listOpts.TotalCount))`
`105`	`106`	`}`
	`107`	`+ if listOpts.CrkID != nil {`
	`108`	`+ values.Set("crk_id", *listOpts.CrkID)`
	`109`	`+ }`
`106`	`110`	`req.URL.RawQuery = values.Encode()`
`107`	`111`	`}`
`108`	`112`