Don't Propagate Attributes on Disabled Instance Policy #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephaniegalang
changed the title
Signed-off-by: stephaniegalang <[email protected]>
stephaniegalang
force-pushed
the
sgal-disabled-pol-attr
branch
from
11a2e97 to
d5cb05d
Compare
stephaniegalang
approved these changes
May 13, 2024
MDarmawan
pushed a commit
to MDarmawan/keyprotect-go-client
that referenced
this pull request
May 30, 2024
Signed-off-by: stephaniegalang <[email protected]> Co-authored-by: stephaniegalang <[email protected]> Signed-off-by: Michael Darmawan <[email protected]>
stephaniegalang
pushed a commit
that referenced
this pull request
Jun 3, 2024
* rename keyring path for conflicts Signed-off-by: Michael Darmawan <[email protected]> * initial implementation of adapters and certs Signed-off-by: Michael Darmawan <[email protected]> * add kmip objects, fix some stuff Signed-off-by: Michael Darmawan <[email protected]> * fix structs Signed-off-by: Michael Darmawan <[email protected]> * unit tests, and some fixes Signed-off-by: Michael Darmawan <[email protected]> * remove import cycle Signed-off-by: Michael Darmawan <[email protected]> * redo mocks Signed-off-by: Michael Darmawan <[email protected]> * add mockauth Signed-off-by: Michael Darmawan <[email protected]> * fix mobk paths Signed-off-by: Michael Darmawan <[email protected]> * fix marshalling Signed-off-by: Michael Darmawan <[email protected]> * fix delete tests Signed-off-by: Michael Darmawan <[email protected]> * remove old kmip profile data Signed-off-by: Michael Darmawan <[email protected]> * address PR comments Signed-off-by: Michael Darmawan <[email protected]> * finish address comments Signed-off-by: Michael Darmawan <[email protected]> * hardcode mock responses, refactor kmip collection metadata Signed-off-by: Michael Darmawan <[email protected]> * fix tests? Signed-off-by: Michael Darmawan <[email protected]> * fix typo Signed-off-by: Michael Darmawan <[email protected]> * add object filter, overhaul list options Signed-off-by: Michael Darmawan <[email protected]> * enhance tests Signed-off-by: Michael Darmawan <[email protected]> * unexport path variables, add comments Signed-off-by: Michael Darmawan <[email protected]> * sdk fixes Signed-off-by: Michael Darmawan <[email protected]> * remove crk from adapter list Signed-off-by: Michael Darmawan <[email protected]> * add crkID filter Signed-off-by: Michael Darmawan <[email protected]> * feat(build): Update travis distribution in CI file (#123) * change travis dist Signed-off-by: Michael Darmawan <[email protected]> * add npm install check to travis Signed-off-by: Michael Darmawan <[email protected]> * real fix Signed-off-by: Michael Darmawan <[email protected]> * change python version Signed-off-by: Michael Darmawan <[email protected]> * remove pyenv, let it use default python version of 3.10 Signed-off-by: Michael Darmawan <[email protected]> --------- Signed-off-by: Michael Darmawan <[email protected]> * add info to contributing about the semantic release (#124) Signed-off-by: Michael Darmawan <[email protected]> * instpol attrib enabled only (#125) Signed-off-by: stephaniegalang <[email protected]> Co-authored-by: stephaniegalang <[email protected]> Signed-off-by: Michael Darmawan <[email protected]> * Allow instance policy attributes to be optionally specified (#126) * allow attributes to be specified optionally Signed-off-by: stephaniegalang <[email protected]> * propogate attributes, ignoring disable Signed-off-by: stephaniegalang <[email protected]> --------- Signed-off-by: stephaniegalang <[email protected]> Co-authored-by: stephaniegalang <[email protected]> Signed-off-by: Michael Darmawan <[email protected]> * fix missed merge artifacts Signed-off-by: Michael Darmawan <[email protected]> --------- Signed-off-by: Michael Darmawan <[email protected]> Signed-off-by: stephaniegalang <[email protected]> Co-authored-by: William Siew <[email protected]> Co-authored-by: stephaniegalang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Key Protect instance policy API does not allow attributes to be specified when disabling KeyCreateImportAccess and AllowedIP policies. Currently, there is no way to omit attributes when calling
SetInstancePolicies(), thus any call to disable these policies fails with errorINVALID_FIELD_ERR: The field attributes must be: provided only if policy is being enabled.This PR makes it so attributes are ignored when disabling KeyCreateImportAccess and AllowedIP policies (no attribute object is sent during the disable per API's input requirement).
Related to IBM-Cloud/terraform-provider-ibm#5342