Fix Encryption Algorithm field. #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Darmawan <[email protected]>
Signed-off-by: Michael Darmawan <[email protected]>
BrunoHenriques
approved these changes
Aug 25, 2023
Giakhanh-Hoang
approved these changes
Aug 25, 2023
| // Encryption algo field is only for secure import. | ||
| // Only included it if either nonce or IV are specified. | ||
| // API will error if only one of IV or nonce are specified but the other is empty. | ||
| if hasNonce || hasIV { |
There was a problem hiding this comment.
As a note and as discussed, this remains a behavioral difference from v0.10.0 but it is a technically a bug fix that would let users know that they did not supply all the required inputs for a secure import operation. (Previous behavior would result in users unknowingly performing regular import key rather than secure import)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#117 was a partial fix that didn't fix all cases. This will fix it all.