Skip to content

igx-toast position input is not working properly #10305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gmartinezig opened this issue Oct 15, 2021 · 0 comments · Fixed by #10334
Closed

igx-toast position input is not working properly #10305

gmartinezig opened this issue Oct 15, 2021 · 0 comments · Fixed by #10334
Assignees
Labels
🐛 bug Any issue that describes a bug ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@gmartinezig
Copy link

Description

When the "position" input value is set to "top", the toast component is shown at the bottom anyway.

Steps to reproduce

image

Result

The "position" value is ignored.

Expected result

The toast should be placed at top

Workaround

It can be solved setting a value to the "positionSettings" directly instead of setting the "position" value.

Observations

It seems like the "positionSettings" value is initialized internally before the "position" value is set, so it keeps its default "position" value forever. The set of the "position" input is not updating the "positionSettings" vertical direction dinamically.

@gmartinezig gmartinezig added the 🐛 bug Any issue that describes a bug label Oct 15, 2021
@Lipata Lipata assigned valadzhov and unassigned simeonoff Oct 18, 2021
@valadzhov valadzhov added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Oct 20, 2021
@valadzhov valadzhov removed their assignment Oct 22, 2021
@dobromirts dobromirts added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Oct 22, 2021
kdinev added a commit that referenced this issue Nov 2, 2021
…working-10305-master

fix(toast): Adding checks for position settings #10305 - master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Any issue that describes a bug ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants