Skip to content

Fix overlay closing animation duration #10278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 12, 2021
Merged

Fix overlay closing animation duration #10278

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64690d3
fix(overlay): fix overlay closing animation duration
PlamenaMiteva Oct 11, 2021
3e12fd9
Merge branch 'master' into PMiteva/overlay-closing-animation-v.13.0
Lipata Oct 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions projects/igniteui-angular/src/lib/services/overlay/overlay.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -745,9 +745,6 @@ export class IgxOverlayService implements OnDestroy {
wrapperElement.style.transitionDuration = '0ms';
return;
}
if (animationOptions.type === AnimationMetadataType.AnimateRef) {
animationOptions = (animationOptions as AnimationAnimateRefMetadata).animation;
}
if (!animationOptions.options || !animationOptions.options.params) {
return;
}
Expand Down Expand Up @@ -893,6 +890,7 @@ export class IgxOverlayService implements OnDestroy {
private removeModalClasses(info: OverlayInfo) {
if (info.settings.modal) {
const wrapperElement = info.elementRef.nativeElement.parentElement.parentElement;
this.applyAnimationParams(wrapperElement, info.settings.positionStrategy.settings.closeAnimation);
wrapperElement.classList.remove('igx-overlay__wrapper--modal');
wrapperElement.classList.add('igx-overlay__wrapper');
}
Expand Down