Skip to content

V dyulgerov/cancel pinning unpinning row 12.2.x #10353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 1, 2021
Merged

V dyulgerov/cancel pinning unpinning row 12.2.x #10353

merged 9 commits into from
Nov 1, 2021

Conversation

Volen99
Copy link
Contributor

@Volen99 Volen99 commented Oct 25, 2021 •
edited
Loading

Closes #10298

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@Volen99 Volen99 changed the base branch from master to 12.2.x October 25, 2021 06:07
@Volen99 Volen99 requested a review from dobromirts October 25, 2021 06:07
@dobromirts dobromirts added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Oct 25, 2021
@hanastasov hanastasov self-requested a review October 26, 2021 06:10
hanastasov
hanastasov requested changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@hanastasov hanastasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test for it.

hanastasov
hanastasov requested changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@hanastasov hanastasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test for the fix,

@hanastasov hanastasov merged commit 9230d3c into 12.2.x Nov 1, 2021
@hanastasov hanastasov deleted the VDyulgerov/cancel-pinning-unpinning-row-12.2.x branch November 1, 2021 07:55
This was referenced Nov 1, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanastasov hanastasov hanastasov approved these changes

@dobromirts dobromirts Awaiting requested review from dobromirts

Assignees

@dobromirts dobromirts

Labels
version: 12.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable the developer to cancel pinning/unpinning row
4 participants
@Volen99 @hanastasov @dobromirts @zdrawku