-
Notifications
You must be signed in to change notification settings - Fork 161
feat(exporters): added migration comments and test #10444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(exporters): added migration comments and test #10444
Conversation
@igdmdimitrov It seems we need to add the trailing comma (if it exists) to the comment, because it causes an error: |
@igdmdimitrov @jackofdiamond5 @damyanpetev I'm not sure If we should comment the services out in the imports as well? Maybe only in the providers array? |
May be missing something, but is the comment message correct - PS: The linked issue is not a bug btw, more like a nice-to-have enhancement for migrations |
Addressed - now commenting only at the start of the file and mentioning the services used in the file. |
Closes #10247
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes (migrations guidelines)