Skip to content

Change how the default currency code is retrieved #10561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2021

Conversation

hanastasov
Copy link
Contributor

@hanastasov hanastasov commented Nov 18, 2021

Closes #10556) ](https://github.com/IgniteUI/igniteui-angular/issues/10556)](https://github.com/IgniteUI/igniteui-angular/issues/10556

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@hanastasov
Copy link
Contributor Author

Will add a test later as well.

@hanastasov hanastasov changed the title Change how the default currency code is retreieved Change how the default currency code is retrieved Nov 18, 2021
@Volen99 Volen99 added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Nov 18, 2021
@hanastasov
Copy link
Contributor Author

With latest changes, we want to make sure that docs is up to date and provide sufficient information on how to use the toolbar: IgniteUI/igniteui-docfx#3029

Fix will not affect AppBuilder, as AppBuilder was doing exactly the same, what users will need to do now - define each action in the igx-grid-toolbar-actions.

Note: Maybe in next minor version allowAdvancedFiltering can be deprecated.

@rkaraivanov rkaraivanov merged commit 4fb5cd0 into master Nov 19, 2021
@rkaraivanov rkaraivanov deleted the fix-getting-currencyCode branch November 19, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid: excel-style-filtering version: 13.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read properties of undefined (reading '_defaultCurrencyCode')
3 participants