Skip to content

Month Picker refactoring #3947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Feb 21, 2019
Merged

Month Picker refactoring #3947

merged 23 commits into from
Feb 21, 2019

Conversation

SAndreeva
Copy link
Contributor

@SAndreeva SAndreeva commented Feb 18, 2019 •
edited
Loading

Related #3126

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@SAndreeva SAndreeva added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Feb 19, 2019
@sboykova sboykova added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Feb 20, 2019
@SAndreeva SAndreeva requested a review from sboykova February 20, 2019 08:02
@sboykova
Copy link
Contributor

Year should be increased/decreased in month view when in focus with the keys LEFT/RIGHT.

sboykova
sboykova previously approved these changes Feb 20, 2019
View reviewed changes
@sboykova sboykova added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Feb 21, 2019
@kdinev kdinev merged commit 9fb1b18 into master Feb 21, 2019
@kdinev kdinev deleted the SAndreeva/month-picker-refactoring branch February 21, 2019 21:05
This was referenced Mar 1, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sboykova sboykova sboykova approved these changes

@rkaraivanov rkaraivanov rkaraivanov approved these changes

@bkulov bkulov Awaiting requested review from bkulov

@simeonoff simeonoff Awaiting requested review from simeonoff

Assignees

@sboykova sboykova

Labels
📆 calendar refactoring version: 7.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SAndreeva @sboykova @rkaraivanov @kdinev @simeonoff